Bug 73288

Summary: Upstream platform/network/blackberry/ProxyServerBlackBerry.cpp
Product: WebKit Reporter: Leo Yang <leo.yang>
Component: PlatformAssignee: Leo Yang <leo.yang>
Status: RESOLVED FIXED    
Severity: Normal CC: charles.wei, dbates, rwlbuis, staikos, zimmermann
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 73144    
Attachments:
Description Flags
Patch tonikitoo: review+

Description Leo Yang 2011-11-29 00:17:50 PST 
The BlackBerry implement of ProxyServerBlackBerry.cpp.
Comment 1 Leo Yang 2011-11-29 00:22:53 PST 
Created attachment 116908 [details]
Patch
Comment 2 Antonio Gomes 2011-11-29 06:52:50 PST 
Comment on attachment 116908 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=116908&action=review

No RIM copyright needed?

> Source/WebCore/platform/network/blackberry/ProxyServerBlackBerry.cpp:35
> +    // FIXME: Implement.

It could be a notImplemented() call.
Comment 3 Leo Yang 2011-11-29 18:04:44 PST 
(In reply to comment #2)
> (From update of attachment 116908 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=116908&action=review
> 
> No RIM copyright needed?
> 
No, it's copied from the other port.

> > Source/WebCore/platform/network/blackberry/ProxyServerBlackBerry.cpp:35
> > +    // FIXME: Implement.
> 
> It could be a notImplemented() call.
Good idea, I'll add it when landing.

Thanks for review.
Comment 4 Leo Yang 2011-11-29 19:19:42 PST 
Committed r101444: <http://trac.webkit.org/changeset/101444>