Bug 73218
Summary: | Chromium fails to build on Windows with WebKit.gyp (revision 101168) | ||
---|---|---|---|
Product: | WebKit | Reporter: | Emanuel Somosan <emanuel> |
Component: | New Bugs | Assignee: | Nobody <webkit-unassigned> |
Status: | RESOLVED WONTFIX | ||
Severity: | Normal | CC: | peter |
Priority: | P2 | ||
Version: | 528+ (Nightly build) | ||
Hardware: | PC | ||
OS: | Windows 7 |
Emanuel Somosan
It looks like WebKit.gyp is missing the exclude for non Android platforms
inside of the webkit target.
This leads to an include of android/WebInputEventFactory.cpp inside of
the VS2010 project which leads to a failed build.
This should fix it:
===================================================================
--- WebKit/chromium/WebKit.gyp (revision 101168)
+++ WebKit/chromium/WebKit.gyp (working copy)
@@ -772,6 +772,10 @@
'include_dirs': [
'public/android',
],
+ }, { # else: not android
+ 'sources/': [
+ ['exclude', '/android/'],
+ ],
}],
['OS=="mac"', {
'include_dirs': [
Attachments | ||
---|---|---|
Add attachment proposed patch, testcase, etc. |
Stephen Chenney
Marking test failures as WontFix. Bug is still accessible and recording in TestExpectations.