Bug 73217

Summary: Web Inspector: remove WebInspector.linkifyURL and TreeElement.titleHTML
Product: WebKit Reporter: Andrey Kosyakov <caseq>
Component: Web Inspector (Deprecated)Assignee: Andrey Kosyakov <caseq>
Status: RESOLVED FIXED    
Severity: Normal CC: apavlov, bweinstein, joepeck, keishi, loislo, pfeldman, pmuellr, rik, timothy, vsevik, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
none
Patch pfeldman: review+

Andrey Kosyakov
Reported 2011-11-28 06:51:50 PST
Building HTML snippets and assigning these to Element.innerHTML is inefficient and potentially insecure. This patch removes most of the occurrences of hand-crafted HTML within the inspector in favor of building and passing DOM elements/fragments.
Attachments
Patch (26.31 KB, patch)
2011-11-28 07:36 PST, Andrey Kosyakov 		no flags
DetailsFormatted DiffDiff
Patch (26.38 KB, patch)
2011-11-28 08:48 PST, Andrey Kosyakov 		pfeldman: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Andrey Kosyakov
Comment 1 2011-11-28 07:36:01 PST
Created attachment 116757 [details] Patch
Vsevolod Vlasov
Comment 2 2011-11-28 08:40:53 PST
Comment on attachment 116757 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=116757&action=review > Source/WebCore/inspector/front-end/ResourceHeadersView.js:147 > + div.createChild("error-message").textContent = WebInspector.UIString("(unable to decode value)"); div.createChild("span", "error-message").textContent > Source/WebCore/inspector/front-end/ResourceHeadersView.js:328 > + value.createChild("span", "status-from-cache").textContent = WebInspector.UIString("(from cache)"); Looks like a whitespace is missing here. Otherwise looks good, but please test different network scenarios prior to landing.
Andrey Kosyakov
Comment 3 2011-11-28 08:48:59 PST
Created attachment 116766 [details] Patch
Andrey Kosyakov
Comment 4 2011-11-28 08:50:14 PST
- fixed space before "(from cache)" - fixed missing "span" in createChild - fixed adding of tree nodes with no title
Andrey Kosyakov
Comment 5 2011-11-29 01:28:59 PST
Committed r101341: <http://trac.webkit.org/changeset/101341>
Note You need to log in before you can comment on or make changes to this bug.