Bug 73216

Summary: [GTK] Add a method to detect 'make dist' errors without running 'make dist'
Product: WebKit Reporter: Martin Robinson <mrobinson>
Component: WebKitGTKAssignee: Martin Robinson <mrobinson>
Status: RESOLVED FIXED    
Severity: Normal CC: cgarcia, pnormand
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch pnormand: review+

Martin Robinson
Reported 2011-11-28 06:47:16 PST
'make dist' takes a long time to run and running it once for every file missing on the source list is incredibly painful. We should just try guess which files are missing by inspecting the generated GNUmakefile and the Plo (header dependencies) files.
Attachments
Patch (5.75 KB, patch)
2011-11-28 11:00 PST, Martin Robinson 		pnormand: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Martin Robinson
Comment 1 2011-11-28 11:00:39 PST
Created attachment 116783 [details] Patch
Philippe Normand
Comment 2 2011-11-29 12:21:18 PST
Comment on attachment 116783 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=116783&action=review Nice. Maybe at some point we can get the bots to run this script? > Tools/gtk/find-make-dist-errors:59 > +def scan_headers_from_depedency_files(): typo: depedency
Martin Robinson
Comment 3 2011-11-29 12:30:31 PST
Committed r101404: <http://trac.webkit.org/changeset/101404>
Note You need to log in before you can comment on or make changes to this bug.