Bug 73195

Summary: [chromium] Disable compositing for RTL pages even in forceCompositingMode
Product: WebKit Reporter: Matt Falkenhagen <falken>
Component: WebCore Misc.Assignee: Matt Falkenhagen <falken>
Status: RESOLVED FIXED    
Severity: Normal CC: enne, jamesr, vangelis, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
RTL-fix
none
rebase vangelis@ patch and add changelog none

Matt Falkenhagen
Reported 2011-11-28 01:28:06 PST
It seems the forceCompositingMode overrides the checks that normally disable GPU compositing on RTL pages, and this is causing renderer hangs. Since forceCompositingMode is on by default in Chrome OS R15 and R16, we probably don't want this. I have prepared a patch, but am not too sure it is the correct thing. I verified at least it stops the renderer hang on RTL pages on ToT Linux. The corresponding Chrome OS bug is http://code.google.com/p/chromium-os/issues/detail?id=20666
Attachments
Patch (1.51 KB, patch)
2011-11-28 01:30 PST, Matt Falkenhagen 		no flags
DetailsFormatted DiffDiff
RTL-fix (2.10 KB, patch)
2011-11-28 10:19 PST, Vangelis Kokkevis 		no flags
DetailsFormatted DiffDiff
rebase vangelis@ patch and add changelog (3.11 KB, patch)
2011-11-28 19:43 PST, Matt Falkenhagen 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Matt Falkenhagen
Comment 1 2011-11-28 01:30:37 PST
Created attachment 116711 [details] Patch
Adrienne Walker
Comment 2 2011-11-28 08:59:28 PST
That check looks like something that should have been there in the first place.
Vangelis Kokkevis
Comment 3 2011-11-28 10:19:58 PST
Created attachment 116778 [details] RTL-fix I think a better place for disabling forceCompositingMode is actually in RenderLayerCompositor::cacheAcceleratedCompositingFlags() . It just needs to be moved a bit further down, after the RTL check is done.
Matt Falkenhagen
Comment 4 2011-11-28 19:43:49 PST
Created attachment 116872 [details] rebase vangelis@ patch and add changelog
WebKit Review Bot
Comment 5 2011-11-28 20:34:35 PST
Comment on attachment 116872 [details] rebase vangelis@ patch and add changelog Clearing flags on attachment: 116872 Committed r101322: <http://trac.webkit.org/changeset/101322>
WebKit Review Bot
Comment 6 2011-11-28 20:34:39 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.