Bug 73178

Summary:

Either remove the GetMethod node from the DFG backend, or find a use for it

Product:

WebKit

Reporter:

Filip Pizlo <fpizlo>

Component:

JavaScriptCore

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Bug Depends on:

73175

Bug Blocks:

Attachments:

Description	Flags
the patch	none

Filip Pizlo

Reported 2011-11-27 18:05:14 PST

The GetMethod node is no longer emitted by the DFG's byte code parser. It may be that this node could still be useful for situations where we're not confident enough in the structure of the base of a GetById to issue CheckStructure nodes, but we've got enough confidence in its monomorphism that we don't want to drop all the way down to a GetById. But most likely, if we don't find a use for GetMethod in the near term, we should just remove the supporting code.

Attachments
the patch (24.72 KB, patch) 2011-11-28 13:19 PST, Filip Pizlo	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Filip Pizlo

Comment 1 2011-11-28 13:19:46 PST

Created attachment 116805 [details] the patch

Filip Pizlo

Comment 2 2011-11-28 13:26:18 PST

Comment on attachment 116805 [details] the patch r=gavin

Filip Pizlo

Comment 3 2011-11-28 14:48:54 PST

Landed in http://trac.webkit.org/changeset/101283

Filip Pizlo

Comment 4 2011-11-28 14:49:09 PST

Comment on attachment 116805 [details] the patch Clearing flags.

Note You need to log in before you can comment on or make changes to this bug.