Bug 73174

Summary: Change set 101187 from bug 73154 removed already lower case optimization
Product: WebKit Reporter: Michael Saboff <msaboff>
Component: JavaScriptCoreAssignee: Michael Saboff <msaboff>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch ggaren: review+

Michael Saboff
Reported 2011-11-27 13:53:41 PST
The patch landed in <http://trac.webkit.org/changeset/101187> did not include the prior "is already lower case" optimization.
Attachments
Patch (1.44 KB, patch)
2011-11-27 13:59 PST, Michael Saboff 		ggaren: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Michael Saboff
Comment 1 2011-11-27 13:59:26 PST
Created attachment 116679 [details] Patch
Geoffrey Garen
Comment 2 2011-11-28 11:45:56 PST
Comment on attachment 116679 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=116679&action=review r=me with one change below. > Source/JavaScriptCore/runtime/StringPrototype.cpp:1196 > + return JSValue::encode(jsString(exec, UString(lower))); lower.release() is the idiom for avoiding refcount churn here.
Michael Saboff
Comment 3 2011-11-28 13:42:54 PST
Committed r101278: <http://trac.webkit.org/changeset/101278>
Note You need to log in before you can comment on or make changes to this bug.