Bug 73125 – StorageEvent.key should not be nullable

• Component: DOM
• Status: RESOLVED FIXED

[Kentaro Hara]

Created attachment 116600 [details]
test cases

Currently, document.createEvent('StorageEvent').key is evaluated as null. However, the spec (http://www.whatwg.org/specs/web-apps/current-work/#storageevent) says that StorageEvent.key is not a nullable type, and thus document.createEvent('StorageEvent').key should be '' (an empty string).

I attached test cases. The results of the test cases are as follows:

According to the spec:
document.createEvent('StorageEvent').key => ""
document.createEvent('StorageEvent').oldValue => "null"
document.createEvent('StorageEvent').newValue => "null"
document.createEvent('StorageEvent').url => ""

Chromium 16.0.912.41 beta (WebKit r100218):
document.createEvent('StorageEvent').key => "null"
document.createEvent('StorageEvent').oldValue => "null"
document.createEvent('StorageEvent').newValue => "null"
document.createEvent('StorageEvent').url => ""

Opera 11.52:
document.createEvent('StorageEvent').key => "undefined"
document.createEvent('StorageEvent').oldValue => "undefined"
document.createEvent('StorageEvent').newValue => "undefined"
document.createEvent('StorageEvent').url => ""

Firefox 8.0.1:
(Not implemented)

IE 9.0.8.112:
(Not implemented)

In this way, all browsers behave differently. Therefore I think that it is reasonable for WebKit to follow the spec.

[Kentaro Hara]

Created attachment 116605 [details]
Patch

[WebKit Review Bot]

Comment on attachment 116605 [details]
Patch

Clearing flags on attachment: 116605

Committed r101453: <http://trac.webkit.org/changeset/101453>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.