Bug 73120

Summary: [EFL] Added DEFAULT_CACHE_SIZE define
Product: WebKit Reporter: Tomasz Morawski <t.morawski>
Component: WebKit EFLAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: gyuyoung.kim, hyuki.kim, lucas.de.marchi, rakuco, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Added DEFAULT_CACHE_SIZE define
none
Patch 2
none
Patch 3 none

Tomasz Morawski
Reported 2011-11-25 02:54:26 PST
Remove form code 40960000 value used in code directly and replaced it by DEFAULT_CACHE_SIZE define. The code looks more cleaner now.
Attachments
Added DEFAULT_CACHE_SIZE define (1.71 KB, patch)
2011-11-25 02:55 PST, Tomasz Morawski 		no flags
DetailsFormatted DiffDiff
Patch 2 (1.68 KB, patch)
2011-11-28 00:47 PST, Tomasz Morawski 		no flags
DetailsFormatted DiffDiff
Patch 3 (1.71 KB, patch)
2011-11-29 00:40 PST, Tomasz Morawski 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Tomasz Morawski
Comment 1 2011-11-25 02:55:32 PST
Created attachment 116588 [details] Added DEFAULT_CACHE_SIZE define
Raphael Kubo da Costa (:rakuco)
Comment 2 2011-11-25 04:45:03 PST
Comment on attachment 116588 [details] Added DEFAULT_CACHE_SIZE define View in context: https://bugs.webkit.org/attachment.cgi?id=116588&action=review > Source/WebKit/efl/ChangeLog:9 > + looks more cleaner now. more cleaner -> cleaner > Source/WebKit/efl/ewk/ewk_tiled_matrix.cpp:68 > +#define DEFAULT_CACHE_SIZE 40960000 I'd rather use a static const size_t instead of a #define here.
Raphael Kubo da Costa (:rakuco)
Comment 3 2011-11-25 04:45:54 PST
(In reply to comment #2) > (From update of attachment 116588 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=116588&action=review > > Source/WebKit/efl/ewk/ewk_tiled_matrix.cpp:68 > > +#define DEFAULT_CACHE_SIZE 40960000 > > I'd rather use a static const size_t instead of a #define here. A comment next to it indicating how much this is in KB or MB would be helpful too.
Tomasz Morawski
Comment 4 2011-11-28 00:47:13 PST
Created attachment 116706 [details] Patch 2
Gyuyoung Kim
Comment 5 2011-11-28 00:48:23 PST
Comment on attachment 116706 [details] Patch 2 LGTM.
KwangHyuk
Comment 6 2011-11-28 00:59:36 PST
LGTM too. :)
Raphael Kubo da Costa (:rakuco)
Comment 7 2011-11-28 05:03:19 PST
Comment on attachment 116706 [details] Patch 2 View in context: https://bugs.webkit.org/attachment.cgi?id=116706&action=review > Source/WebKit/efl/ewk/ewk_tiled_matrix.cpp:68 > +const size_t DEFAULT_CACHE_SIZE = 40 * 1024 * 1024; static const, not const.
Tomasz Morawski
Comment 8 2011-11-29 00:40:58 PST
Created attachment 116911 [details] Patch 3
Raphael Kubo da Costa (:rakuco)
Comment 9 2011-11-29 06:54:21 PST
Comment on attachment 116911 [details] Patch 3 LGTM.
Gyuyoung Kim
Comment 10 2011-11-29 17:32:47 PST
Comment on attachment 116911 [details] Patch 3 LGTM too.
Filip Pizlo
Comment 11 2011-11-30 00:48:53 PST
Comment on attachment 116911 [details] Patch 3 r=me
WebKit Review Bot
Comment 12 2011-11-30 01:22:25 PST
Comment on attachment 116911 [details] Patch 3 Clearing flags on attachment: 116911 Committed r101462: <http://trac.webkit.org/changeset/101462>
WebKit Review Bot
Comment 13 2011-11-30 01:22:30 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.