Bug 73090

Summary: InspectorServer: Generic Server Socket to be used for a WebSocket Server
Product: WebKit Reporter: Jocelyn Turcotte <jturcotte>
Component: Web Inspector (Deprecated)Assignee: Jocelyn Turcotte <jturcotte>
Status: RESOLVED INVALID    
Severity: Enhancement CC: hausmann
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Original patch
none
Patch none

Jocelyn Turcotte
Reported 2011-11-24 12:08:56 PST
Created attachment 116528 [details] Original patch Tracks the "New Part 1" patch of bug #51364.
Attachments
Original patch (32.96 KB, patch)
2011-11-24 12:08 PST, Jocelyn Turcotte 		no flags
DetailsFormatted DiffDiff
Patch (29.68 KB, patch)
2011-11-24 13:09 PST, Jocelyn Turcotte 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Jocelyn Turcotte
Comment 1 2011-11-24 13:09:55 PST
Created attachment 116534 [details] Patch
Pavel Feldman
Comment 2 2011-11-25 00:21:15 PST
Comment on attachment 116534 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=116534&action=review > Source/WebCore/ChangeLog:8 > + Add a generic Server Socket interface and an implementation for platform/qt. It is not clear to me why we need a generic interface in the WebCore given that all the implementations are platform-specific and the only usage is from outside WebCore.
Jocelyn Turcotte
Comment 3 2011-11-25 04:22:24 PST
(In reply to comment #2) > It is not clear to me why we need a generic interface in the WebCore given that all the implementations are platform-specific and the only usage is from outside WebCore. There isn't much gain from the abstraction today I agree, ServerSocketHandleBase could be merged into WebSocketServer (bug #73093) along with it's platform specific parts. We can extract the server socket logic out of it in the future if something else needs it.
Jocelyn Turcotte
Comment 4 2011-12-05 12:52:01 PST
This bug is obsolete and has been merged in WebSocketServer in bug #73093 as per comments.
Note You need to log in before you can comment on or make changes to this bug.