Bug 73084

Summary:

Web Inspector: [Extensions API] pass preferred resource line number to extension's open resource handler

Product:

WebKit

Reporter:

Andrey Kosyakov <caseq>

Component:

Web Inspector (Deprecated)

Assignee:

Andrey Kosyakov <caseq>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

apavlov, bweinstein, joepeck, keishi, loislo, pfeldman, pmuellr, rik, timothy, yurys

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
Patch	pfeldman: review+

Description Andrey Kosyakov 2011-11-24 09:39:46 PST

When it makes sense to display a specific line for the resource (e.g. context menu invoked from a line within the resource text or click on a error message with a line number), the extension's handler set by webInspector.panels.setOpenResourceHandler() should receive the line number.

Comment 1 Andrey Kosyakov 2011-12-01 09:32:28 PST

Created attachment 117436 [details]
Patch

Comment 2 Pavel Feldman 2011-12-01 09:46:03 PST

Comment on attachment 117436 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=117436&action=review

> Source/WebCore/inspector/front-end/ExtensionServer.js:285
> +        var preferredLineNumber = details.preferredLineNumber;

lineNumber?

Comment 3 Andrey Kosyakov 2011-12-02 02:17:51 PST

Committed r101769: <http://trac.webkit.org/changeset/101769>