Bug 73080

Summary: [GTK] WebAudio wav resources access and management
Product: WebKit Reporter: Philippe Normand <pnormand>
Component: WebKitGTKAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: donggwan.kim, mrobinson
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 61355    
Attachments:
Description Flags
proposed patch mrobinson: review+

Philippe Normand
Reported 2011-11-24 07:17:45 PST
We need to dist the platform/audio/resources and add a case in the GTK AudioBus implementation for accessing those in the uninstalled case.
Attachments
proposed patch (3.46 KB, patch)
2011-11-25 02:21 PST, Philippe Normand 		mrobinson: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Philippe Normand
Comment 1 2011-11-25 02:21:55 PST
Created attachment 116585 [details] proposed patch
Martin Robinson
Comment 2 2011-11-30 13:27:02 PST
Comment on attachment 116585 [details] proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=116585&action=review > Source/WebCore/platform/audio/gtk/AudioBusGtk.cpp:41 > + absoluteFilename.set(g_build_filename(UNINSTALLED_AUDIO_RESOURCES_DIR, filename.get(), NULL)); Maybe it's better to pass this as an environment variable similar to what we do for other variables like this.
Philippe Normand
Comment 3 2011-11-30 13:44:39 PST
Comment on attachment 116585 [details] proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=116585&action=review >> Source/WebCore/platform/audio/gtk/AudioBusGtk.cpp:41 >> + absoluteFilename.set(g_build_filename(UNINSTALLED_AUDIO_RESOURCES_DIR, filename.get(), NULL)); > > Maybe it's better to pass this as an environment variable similar to what we do for other variables like this. Hum I grepped around for getenv and failed to encounter such similar situation. That env var would be set by run-launcher?
Martin Robinson
Comment 4 2011-11-30 13:46:39 PST
They are typically in WebKit. One example is WEBKIT_INSPECTOR_PATH.
Philippe Normand
Comment 5 2011-12-01 02:48:56 PST
Committed r101644: <http://trac.webkit.org/changeset/101644>
Note You need to log in before you can comment on or make changes to this bug.