Summary: | [GTK] WebAudio wav resources access and management | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Philippe Normand <pnormand> | ||||
Component: | WebKitGTK | Assignee: | Nobody <webkit-unassigned> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | donggwan.kim, mrobinson | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Bug Depends on: | |||||||
Bug Blocks: | 61355 | ||||||
Attachments: |
|
Description
Philippe Normand
2011-11-24 07:17:45 PST
Created attachment 116585 [details]
proposed patch
Comment on attachment 116585 [details] proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=116585&action=review > Source/WebCore/platform/audio/gtk/AudioBusGtk.cpp:41 > + absoluteFilename.set(g_build_filename(UNINSTALLED_AUDIO_RESOURCES_DIR, filename.get(), NULL)); Maybe it's better to pass this as an environment variable similar to what we do for other variables like this. Comment on attachment 116585 [details] proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=116585&action=review >> Source/WebCore/platform/audio/gtk/AudioBusGtk.cpp:41 >> + absoluteFilename.set(g_build_filename(UNINSTALLED_AUDIO_RESOURCES_DIR, filename.get(), NULL)); > > Maybe it's better to pass this as an environment variable similar to what we do for other variables like this. Hum I grepped around for getenv and failed to encounter such similar situation. That env var would be set by run-launcher? They are typically in WebKit. One example is WEBKIT_INSPECTOR_PATH. Committed r101644: <http://trac.webkit.org/changeset/101644> |