Bug 7308

Summary: DumpRenderTree should be able to load files via HTTP
Product: WebKit Reporter: Alexey Proskuryakov <ap>
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Enhancement    
Priority: P2    
Version: 420+   
Hardware: Mac   
OS: OS X 10.4   
Bug Depends on:    
Bug Blocks: 6197    
Attachments:
Description Flags
proposed patch darin: review+

Alexey Proskuryakov
Reported 2006-02-16 12:13:45 PST
This is needed for tests that cannot function without a live HTTP server.
Attachments
proposed patch (1.90 KB, patch)
2006-02-16 12:15 PST, Alexey Proskuryakov 		darin: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Alexey Proskuryakov
Comment 1 2006-02-16 12:15:29 PST
Created attachment 6548 [details] proposed patch
Geoffrey Garen
Comment 2 2006-02-16 13:56:51 PST
I thought the goal was to remove HTTP access from run-webkit-tests entirely, to immediately detect tests that incorrectly include non-local resources.
Alexey Proskuryakov
Comment 3 2006-02-16 14:31:11 PST
(In reply to comment #2) I think this is orthogonal - it should hopefully be possible to disable HTTP selectively, only for tests that are loaded from the file system.
Darin Adler
Comment 4 2006-02-17 19:40:56 PST
Comment on attachment 6548 [details] proposed patch Seems fine. I was thinking, though, that we might go the other direction and forbid I/O completely inside DumpRenderTree, to avoid tests that accidentally use network resources. r=me
Note You need to log in before you can comment on or make changes to this bug.