Bug 73050

Summary: Change CSSMutableStyleDeclaration::m_node to m_element (along with getter/setter)
Product: WebKit Reporter: Rafael Weinstein <rafaelw>
Component: CSSAssignee: Rafael Weinstein <rafaelw>
Status: RESOLVED FIXED    
Severity: Normal CC: darin, gustavo.noronha, gustavo, macpherson, ojan, rniwa, sam, webkit.review.bot, xan.lopez
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Rafael Weinstein
Reported 2011-11-23 14:04:34 PST
It is always set as an element, and clients often have to re-cast to an element
Attachments
Patch (14.63 KB, patch)
2011-11-23 14:06 PST, Rafael Weinstein 		no flags
DetailsFormatted DiffDiff
Patch (15.30 KB, patch)
2011-11-23 15:08 PST, Rafael Weinstein 		no flags
DetailsFormatted DiffDiff
Patch (15.50 KB, patch)
2011-11-23 15:21 PST, Rafael Weinstein 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Rafael Weinstein
Comment 1 2011-11-23 14:06:23 PST
Created attachment 116423 [details] Patch
Ryosuke Niwa
Comment 2 2011-11-23 14:27:48 PST
Comment on attachment 116423 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=116423&action=review > Source/WebCore/css/CSSMutableStyleDeclaration.h:181 > - Node* m_node; > + Element* m_element; Why not StyledElement?
Early Warning System Bot
Comment 3 2011-11-23 14:28:13 PST
Comment on attachment 116423 [details] Patch Attachment 116423 [details] did not pass qt-ews (qt): Output: http://queues.webkit.org/results/10602402
Collabora GTK+ EWS bot
Comment 4 2011-11-23 14:45:40 PST
Comment on attachment 116423 [details] Patch Attachment 116423 [details] did not pass gtk-ews (gtk): Output: http://queues.webkit.org/results/10651009
Rafael Weinstein
Comment 5 2011-11-23 15:05:32 PST
Comment on attachment 116423 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=116423&action=review >> Source/WebCore/css/CSSMutableStyleDeclaration.h:181 >> + Element* m_element; > > Why not StyledElement? good call. done
Rafael Weinstein
Comment 6 2011-11-23 15:08:09 PST
Created attachment 116436 [details] Patch
Early Warning System Bot
Comment 7 2011-11-23 15:18:59 PST
Comment on attachment 116436 [details] Patch Attachment 116436 [details] did not pass qt-ews (qt): Output: http://queues.webkit.org/results/10640009
Rafael Weinstein
Comment 8 2011-11-23 15:21:55 PST
Created attachment 116443 [details] Patch
WebKit Review Bot
Comment 9 2011-11-23 18:45:18 PST
Comment on attachment 116443 [details] Patch Clearing flags on attachment: 116443 Committed r101116: <http://trac.webkit.org/changeset/101116>
WebKit Review Bot
Comment 10 2011-11-23 18:45:24 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.