Bug 73050

Summary: Change CSSMutableStyleDeclaration::m_node to m_element (along with getter/setter)
Product: WebKit Reporter: Rafael Weinstein <rafaelw>
Component: CSSAssignee: Rafael Weinstein <rafaelw>
Status: RESOLVED FIXED    
Severity: Normal CC: darin, gustavo.noronha, gustavo, macpherson, ojan, rniwa, sam, webkit.review.bot, xan.lopez
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Description Rafael Weinstein 2011-11-23 14:04:34 PST 
It is always set as an element, and clients often have to re-cast to an element
Comment 1 Rafael Weinstein 2011-11-23 14:06:23 PST 
Created attachment 116423 [details]
Patch
Comment 2 Ryosuke Niwa 2011-11-23 14:27:48 PST 
Comment on attachment 116423 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=116423&action=review

> Source/WebCore/css/CSSMutableStyleDeclaration.h:181
> -    Node* m_node;
> +    Element* m_element;

Why not StyledElement?
Comment 3 Early Warning System Bot 2011-11-23 14:28:13 PST 
Comment on attachment 116423 [details]
Patch

Attachment 116423 [details] did not pass qt-ews (qt):
Output: http://queues.webkit.org/results/10602402
Comment 4 Collabora GTK+ EWS bot 2011-11-23 14:45:40 PST 
Comment on attachment 116423 [details]
Patch

Attachment 116423 [details] did not pass gtk-ews (gtk):
Output: http://queues.webkit.org/results/10651009
Comment 5 Rafael Weinstein 2011-11-23 15:05:32 PST 
Comment on attachment 116423 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=116423&action=review

>> Source/WebCore/css/CSSMutableStyleDeclaration.h:181
>> +    Element* m_element;
> 
> Why not StyledElement?

good call. done
Comment 6 Rafael Weinstein 2011-11-23 15:08:09 PST 
Created attachment 116436 [details]
Patch
Comment 7 Early Warning System Bot 2011-11-23 15:18:59 PST 
Comment on attachment 116436 [details]
Patch

Attachment 116436 [details] did not pass qt-ews (qt):
Output: http://queues.webkit.org/results/10640009
Comment 8 Rafael Weinstein 2011-11-23 15:21:55 PST 
Created attachment 116443 [details]
Patch
Comment 9 WebKit Review Bot 2011-11-23 18:45:18 PST 
Comment on attachment 116443 [details]
Patch

Clearing flags on attachment: 116443

Committed r101116: <http://trac.webkit.org/changeset/101116>
Comment 10 WebKit Review Bot 2011-11-23 18:45:24 PST 
All reviewed patches have been landed.  Closing bug.