Bug 73004

Summary: DRT isn't updating on chromium linux build.webkit.org bot
Product: WebKit Reporter: Dirk Pranke <dpranke>
Component: Tools / TestsAssignee: Dirk Pranke <dpranke>
Status: RESOLVED FIXED    
Severity: Normal CC: adamk, koz, scottmg, thakis, tony
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Dirk Pranke
Reported 2011-11-22 23:10:47 PST
There appears to be a bug in the Makefile generator for GYP that is causing the chromium linux build on build.webkit.org to not include DRT in the "all" target; the issue seems to be that the DRT target is being resolved two different ways, leading to the DumpRenderTree.target.chromium.mk file getting generated twice; the second time is not pulled in from WebKit.gyp, so it isn't considered to be part of the "all" target. The bug was introduced with the change in chromium r111360 to enable appcache and content to be build as DLLs (this introduced a dependency on WebKit.gyp to the appcache target, causing the problem).
Attachments
Patch (1.22 KB, patch)
2011-11-22 23:12 PST, Dirk Pranke 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Dirk Pranke
Comment 1 2011-11-22 23:12:39 PST
Created attachment 116322 [details] Patch
Dirk Pranke
Comment 2 2011-11-22 23:13:17 PST
Committed r101044: <http://trac.webkit.org/changeset/101044>
Note You need to log in before you can comment on or make changes to this bug.