Bug 72886

Summary: Web Inspector: strip unused InspectorController methods.
Product: WebKit Reporter: Pavel Feldman <pfeldman>
Component: Web Inspector (Deprecated)Assignee: Pavel Feldman <pfeldman>
Status: RESOLVED FIXED    
Severity: Normal CC: apavlov, bweinstein, gustavo.noronha, gustavo, joepeck, keishi, loislo, pfeldman, pmuellr, rik, timothy, xan.lopez, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
none
[Patch] with GTK bot fixed. yurys: review+

Pavel Feldman
Reported 2011-11-21 07:52:38 PST
This is a follow up to https://bugs.webkit.org/show_bug.cgi?id=63009. I am now able to remove following InspectorController methods: ::startUserInitiatedProfiling, ::isRecordingUserInitiatedProfile, ::stopUserInitiatedProfiling, ::showAndEnableDebugger, ::debuggerEnabled, ::disableDebugger, ::startTimelineProfiler, ::stopTimelineProfiler, ::timelineProfilerEnabled, ::showConsole.
Attachments
Patch (27.71 KB, patch)
2011-11-21 08:04 PST, Pavel Feldman 		no flags
DetailsFormatted DiffDiff
[Patch] with GTK bot fixed. (29.28 KB, patch)
2011-11-21 10:09 PST, Pavel Feldman 		yurys: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Pavel Feldman
Comment 1 2011-11-21 08:04:15 PST
Created attachment 116090 [details] Patch
Yury Semikhatsky
Comment 2 2011-11-21 08:09:13 PST
Comment on attachment 116090 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=116090&action=review > Source/WebCore/inspector/InspectorController.h:109 > + Remove this line.
Collabora GTK+ EWS bot
Comment 3 2011-11-21 08:15:11 PST
Comment on attachment 116090 [details] Patch Attachment 116090 [details] did not pass gtk-ews (gtk): Output: http://queues.webkit.org/results/10534283
Pavel Feldman
Comment 4 2011-11-21 10:09:09 PST
Created attachment 116103 [details] [Patch] with GTK bot fixed.
Yury Semikhatsky
Comment 5 2011-11-22 00:45:18 PST
Comment on attachment 116103 [details] [Patch] with GTK bot fixed. View in context: https://bugs.webkit.org/attachment.cgi?id=116103&action=review > Source/WebKit/gtk/webkit/webkitwebinspector.cpp:93 > + PROP_TIMELINE_PROFILING_ENABLED The constant should be removed as well, please discuss it with the Gtk folks.
Pavel Feldman
Comment 6 2011-11-22 01:52:28 PST
Committed r100985: <http://trac.webkit.org/changeset/100985>
Note You need to log in before you can comment on or make changes to this bug.