Bug 72829 – Pass command line arguments to GDB when debugging a Mac WebKit application

• Component: Tools / Tests
• Status: RESOLVED FIXED

[Daniel Bates]

Command line argument given to debug-{safari, mini browser} should pass through to GDB so that they can influence the application instance launched by GDB.

[Daniel Bates]

Created attachment 115989 [details]
Patch

[David Kilzer (:ddkilzer)]

Comment on attachment 115989 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=115989&action=review

r=me

> Tools/Scripts/webkitdirs.pm:2075
> -    exec { $gdbPath } $gdbPath, @architectureFlags, $appPath or die;
> +    exec { $gdbPath } $gdbPath, @architectureFlags, $appPath, @ARGV or die;

NOTE:  This conflicts with Attachment 115993 [details] Bug 66902.  This should either land first, or not at all.

[Daniel Bates]

(In reply to comment #2)
> (From update of attachment 115989 [details])
> [...]
> > Tools/Scripts/webkitdirs.pm:2075
> > -    exec { $gdbPath } $gdbPath, @architectureFlags, $appPath or die;
> > +    exec { $gdbPath } $gdbPath, @architectureFlags, $appPath, @ARGV or die;
> 
> NOTE:  This conflicts with Attachment 115993 [details] Bug 66902.  This should either land first, or not at all.

Will land this patch first. Then will land the patch for bug #66902.

[Daniel Bates]

Committed r103276: <http://trac.webkit.org/changeset/103276>