Bug 72789

Summary: [GTK] GTK+ 3 theming code does not use the GtkOrientable style class
Product: WebKit Reporter: Martin Robinson <mrobinson>
Component: WebKitGTKAssignee: Martin Robinson <mrobinson>
Status: RESOLVED FIXED    
Severity: Normal CC: cgarcia, webkit.review.bot, xan.lopez
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Fix for vertical slider thumbs none

Martin Robinson
Reported 2011-11-19 00:07:00 PST
This causes horizontal sliders to render incorrectly when painting with the unico theme.
Attachments
Patch (7.16 KB, patch)
2011-11-19 00:10 PST, Martin Robinson 		no flags
DetailsFormatted DiffDiff
Fix for vertical slider thumbs (7.23 KB, patch)
2011-11-19 10:14 PST, Martin Robinson 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Martin Robinson
Comment 1 2011-11-19 00:10:48 PST
Created attachment 115936 [details] Patch
Martin Robinson
Comment 2 2011-11-19 10:14:39 PST
Created attachment 115953 [details] Fix for vertical slider thumbs
Carlos Garcia Campos
Comment 3 2011-11-21 00:02:40 PST
Comment on attachment 115953 [details] Fix for vertical slider thumbs I had in mind to review all the theming code, but never found the time. Patch looks good to me. Thanks!
Philippe Normand
Comment 4 2012-01-03 09:31:50 PST
Comment on attachment 115953 [details] Fix for vertical slider thumbs Great, thanks!
WebKit Review Bot
Comment 5 2012-01-03 11:52:03 PST
Comment on attachment 115953 [details] Fix for vertical slider thumbs Clearing flags on attachment: 115953 Committed r103951: <http://trac.webkit.org/changeset/103951>
WebKit Review Bot
Comment 6 2012-01-03 11:52:08 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.