|Summary:||Move gamepad to Modules/ (+ some cleanup)|
|Product:||WebKit||Reporter:||Scott Graham <scottmg>|
|Component:||WebCore Misc.||Assignee:||Scott Graham <scottmg>|
|Severity:||Normal||CC:||abarth, ojan, sam, webkit.review.bot|
|Version:||528+ (Nightly build)|
Description Scott Graham 2011-11-18 18:34:10 PST
Based on discussion here: https://bugs.webkit.org/show_bug.cgi?id=71753 Some gamepad cleanup: - use fast/js/ test harness - add #if ENABLE around headers in Navigator to avoid including them for ports that aren't using them - move from page/ to new Modules/ location
Comment 2 Adam Barth 2011-11-18 19:23:17 PST
Comment on attachment 115924 [details] Patch Looks great. Thanks!
Comment 3 WebKit Review Bot 2011-11-19 12:51:59 PST
Comment on attachment 115924 [details] Patch Clearing flags on attachment: 115924 Committed r100860: <http://trac.webkit.org/changeset/100860>
Comment 4 WebKit Review Bot 2011-11-19 12:52:05 PST
All reviewed patches have been landed. Closing bug.
Comment 5 Sam Weinig 2011-11-19 19:48:18 PST
This patch added (or rather moved I guess) a bunch of files with license headers that use C++ style comments rather than C-style, which is out of the norm.
Comment 6 Adam Barth 2011-11-19 21:51:51 PST
Thanks Sam. Scott, would you be willing to update the license headers to match the common style in WebKit? I presume you copied the license headers from somewhere. Do you remember where so we can align them with the norm as well?