Bug 72767

Summary: [chromium] Use correct backing store for ChromiumDataObject in pasteboard writes.
Product: WebKit Reporter: Daniel Cheng <dcheng>
Component: New BugsAssignee: Daniel Cheng <dcheng>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Daniel Cheng
Reported 2011-11-18 15:28:18 PST
[chromium] Use correct backing store for ChromiumDataObject in pasteboard writes.
Attachments
Patch (9.76 KB, patch)
2011-11-18 15:29 PST, Daniel Cheng 		no flags
DetailsFormatted DiffDiff
Patch (11.45 KB, patch)
2011-11-18 16:30 PST, Daniel Cheng 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Daniel Cheng
Comment 1 2011-11-18 15:29:55 PST
Created attachment 115892 [details] Patch
Daniel Cheng
Comment 2 2011-11-18 15:35:25 PST
There are a couple tests for this, but they are currently disabled. I'd prefer to roll Source/WebKit/chromium/DEPS in a separate patch to enable those tests though.
Tony Chang
Comment 3 2011-11-18 15:53:41 PST
Comment on attachment 115892 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=115892&action=review The change looks fine. Can we roll chromium deps in a separate change than include the test enabling in this change? > Source/WebCore/platform/chromium/ChromiumDataObject.h:102 > + ChromiumDataObject(StorageMode); Nit: explicit
Daniel Cheng
Comment 4 2011-11-18 16:30:37 PST
Created attachment 115906 [details] Patch
Daniel Cheng
Comment 5 2011-11-18 16:31:04 PST
Comment on attachment 115892 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=115892&action=review As it turns out, the chromium revision I need is already rolled into WebKit. I just needed to sync locally. >> Source/WebCore/platform/chromium/ChromiumDataObject.h:102 >> + ChromiumDataObject(StorageMode); > > Nit: explicit Done.
Tony Chang
Comment 6 2011-11-18 16:31:56 PST
Comment on attachment 115906 [details] Patch OK!
Daniel Cheng
Comment 7 2011-11-18 16:46:49 PST
Comment on attachment 115906 [details] Patch Clearing flags on attachment: 115906 Committed r100828: <http://trac.webkit.org/changeset/100828>
Daniel Cheng
Comment 8 2011-11-18 16:46:54 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.