Bug 72764

Summary:

QtTestBrowser -webgl option is ignored

Product:

WebKit

Reporter:

Andrew Wason <rectalogic>

Component:

WebKit Qt

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abecsi, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
define QT_CONFIGURED_WITH_OPENGL	none

Andrew Wason

Reported 2011-11-18 15:04:17 PST

QtTestBrowser -webgl command line option is ignored.

Attachments
define QT_CONFIGURED_WITH_OPENGL (1.06 KB, patch) 2011-11-18 15:08 PST, Andrew Wason	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Andrew Wason

Comment 1 2011-11-18 15:08:22 PST

Created attachment 115883 [details] define QT_CONFIGURED_WITH_OPENGL -webgl option is conditional on QT_CONFIGURED_WITH_OPENGL, define this if configured for opengl.

WebKit Review Bot

Comment 2 2011-11-21 01:15:02 PST

Comment on attachment 115883 [details] define QT_CONFIGURED_WITH_OPENGL Rejecting attachment 115883 [details] from commit-queue. New failing tests: platform/chromium-linux/fast/text/international/complex-joining-using-gpos.html Full output: http://queues.webkit.org/results/10363207

Andrew Wason

Comment 3 2011-11-23 06:45:17 PST

Comment on attachment 115883 [details] define QT_CONFIGURED_WITH_OPENGL I don't see how this would have caused tests to fail, can we retry?

WebKit Review Bot

Comment 4 2011-12-21 19:39:20 PST

Comment on attachment 115883 [details] define QT_CONFIGURED_WITH_OPENGL Rejecting attachment 115883 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: hromium/testing/gmock --revision 374 --non-interactive --force --accept theirs-conflict --ignore-externals returned non-zero exit status 1 in /mnt/git/webkit-commit-queue/Source/WebKit/chromium Error: 'depot_tools/gclient sync --force --reset --delete_unversioned_trees' failed 3 tries and returned 256 at Tools/Scripts/update-webkit-chromium line 106. Re-trying 'depot_tools/gclient sync --force --reset --delete_unversioned_trees' No such file or directory at Tools/Scripts/update-webkit line 112. Full output: http://queues.webkit.org/results/10981279

Andras Becsi

Comment 5 2012-05-22 05:21:32 PDT

Looks like a leftover bug. This is fixed in trunk.

Andras Becsi

Comment 6 2012-05-22 05:21:55 PDT

Comment on attachment 115883 [details] define QT_CONFIGURED_WITH_OPENGL Clearing flags.

Note You need to log in before you can comment on or make changes to this bug.