Bug 72737
| Summary: | Web Inspector: [protocol] actual JSON messages do not conform to Inspector.json in ScriptCallFrame.cpp | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Peter Rybin <peter.rybin> |
| Component: | Web Inspector (Deprecated) | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | apavlov, bburg, bweinstein, joepeck, keishi, loislo, peter.rybin, pfeldman, pmuellr, rik, yurys |
| Priority: | P2 | ||
| Version: | 528+ (Nightly build) | ||
| Hardware: | All | ||
| OS: | All | ||
| Bug Depends on: | |||
| Bug Blocks: | 72824 | ||
Peter Rybin
ScriptCallFrame.cpp:50-51 (r100177)
'lineNumber' and 'columnNumber' are declared 'string', but actual value is 'number'; why are they string anyway?
This should be fixed to conform to protocol declaration AND to prepare switching to type-safe JSON API.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Pavel Feldman
(In reply to comment #0)
> ScriptCallFrame.cpp:50-51 (r100177)
> 'lineNumber' and 'columnNumber' are declared 'string', but actual value is 'number'; why are they string anyway?
>
> This should be fixed to conform to protocol declaration AND to prepare switching to type-safe JSON API.
Should be fixed both in the spec and in the golden.