Bug 72736
| Summary: | Web Inspector: [protocol] actual JSON messages do not conform to Inspector.json in InspectorResourceAgent.cpp | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Peter Rybin <peter.rybin> |
| Component: | Web Inspector (Deprecated) | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED INVALID | ||
| Severity: | Normal | CC: | apavlov, bweinstein, joepeck, keishi, loislo, peter.rybin, pfeldman, pmuellr, rik, yurys |
| Priority: | P2 | ||
| Version: | 528+ (Nightly build) | ||
| Hardware: | All | ||
| OS: | All | ||
| Bug Depends on: | |||
| Bug Blocks: | 72824 | ||
Peter Rybin
InspectorResourceAgent.cpp:179 (r100177)
"response" property must be set unconditionally, because it's not optional.
This should be fixed to conform to protocol declaration AND to prepare switching to type-safe JSON API.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Pavel Feldman
(In reply to comment #0)
> InspectorResourceAgent.cpp:179 (r100177)
> "response" property must be set unconditionally, because it's not optional.
>
Sounds like we'll need to fix the protocol definition. It should be optional.
Brian Burg
Closing as invalid, as this bug pertains to the old inspector UI and/or its tests.
Please file a new bug (https://www.webkit.org/new-inspector-bug) if the bug/feature/issue is still relevant to WebKit trunk.