Bug 72712

Summary: Remove deprecated load-done signal
Product: WebKit Reporter: Kaustubh Atrawalkar <kaustubh.ra>
Component: UI EventsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: kaustubh.ra, mrobinson, rniwa, webkit.review.bot, xan.lopez
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
none
Updated Patch
none
Documentation FIX
none
Updated Patch none

Kaustubh Atrawalkar
Reported 2011-11-18 04:00:37 PST
Signal load-done is deprecated. Need to remove the callbacks for the same. Reference - http://webkitgtk.org/reference/WebKitWebFrame.html#WebKitWebFrame-load-done
Attachments
Patch (3.16 KB, patch)
2011-11-18 04:02 PST, Kaustubh Atrawalkar 		no flags
DetailsFormatted DiffDiff
Updated Patch (2.85 KB, patch)
2011-11-18 22:26 PST, Kaustubh Atrawalkar 		no flags
DetailsFormatted DiffDiff
Documentation FIX (1.15 KB, patch)
2011-11-21 01:25 PST, Kaustubh Atrawalkar 		no flags
DetailsFormatted DiffDiff
Updated Patch (2.99 KB, patch)
2012-02-23 05:08 PST, Kaustubh Atrawalkar 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Kaustubh Atrawalkar
Comment 1 2011-11-18 04:02:30 PST
Created attachment 115784 [details] Patch Attaching patch for the same.
Martin Robinson
Comment 2 2011-11-18 10:42:53 PST
Comment on attachment 115784 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=115784&action=review > Source/WebKit/gtk/webkit/webkitwebframe.cpp:206 > - * WebKitWebFrame::load-done > + * WebKitWebFrame::load-committed Do you mind splitting this fix into another patch?
Kaustubh Atrawalkar
Comment 3 2011-11-18 22:25:50 PST
(In reply to comment #2) > (From update of attachment 115784 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=115784&action=review > > > Source/WebKit/gtk/webkit/webkitwebframe.cpp:206 > > - * WebKitWebFrame::load-done > > + * WebKitWebFrame::load-committed > > Do you mind splitting this fix into another patch? Sure. I can do that. Attaching updated patch.
Kaustubh Atrawalkar
Comment 4 2011-11-18 22:26:31 PST
Created attachment 115930 [details] Updated Patch
Kaustubh Atrawalkar
Comment 5 2011-11-21 01:25:01 PST
Created attachment 116049 [details] Documentation FIX Added documentation fix in another patch.
Kaustubh Atrawalkar
Comment 6 2011-11-21 01:25:31 PST
Martin, can u review both patches? Thanks.
Martin Robinson
Comment 7 2011-11-21 08:26:01 PST
Comment on attachment 116049 [details] Documentation FIX We try to do one patch per bug. If that was the case the bug description wouldn't have to contain two things. Sorry, that I didn't mention this before.
Kaustubh Atrawalkar
Comment 8 2011-11-21 22:19:26 PST
(In reply to comment #7) > (From update of attachment 116049 [details]) > We try to do one patch per bug. If that was the case the bug description wouldn't have to contain two things. Sorry, that I didn't mention this before. No issues. I can make this up in separate bug. Thought this one line change related to same bug would go in same patch. Added another bug - https://bugs.webkit.org/show_bug.cgi?id=72927 Thanks.
Kaustubh Atrawalkar
Comment 9 2012-02-23 05:08:54 PST
Created attachment 128461 [details] Updated Patch I have updated the patch with latest revision. Also migrated load-done to load-status signal. Martin, can you review this one? Thanks.
Brent Fulgham
Comment 10 2012-11-25 21:00:19 PST
Comment on attachment 128461 [details] Updated Patch Looks good.
WebKit Review Bot
Comment 11 2012-11-25 21:13:14 PST
Comment on attachment 128461 [details] Updated Patch Clearing flags on attachment: 128461 Committed r135678: <http://trac.webkit.org/changeset/135678>
WebKit Review Bot
Comment 12 2012-11-25 21:13:19 PST
All reviewed patches have been landed. Closing bug.
Martin Robinson
Comment 13 2012-11-25 21:18:00 PST
Changes to the GTK+ require the approval of two GTK+ port reviewers... We might want to revert this one for now.
Note You need to log in before you can comment on or make changes to this bug.