Bug 72683

Summary: Tune JSStringBuilder for 8 bit Strings
Product: WebKit Reporter: Michael Saboff <msaboff>
Component: JavaScriptCoreAssignee: Michael Saboff <msaboff>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch fpizlo: review+

Michael Saboff
Reported 2011-11-17 17:56:20 PST
Investigate common cases string processing is generic (e.g. using characters()) and could benefit from 8 bit specific processing.
Attachments
Patch (5.68 KB, patch)
2011-11-22 10:30 PST, Michael Saboff 		fpizlo: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Michael Saboff
Comment 1 2011-11-22 10:19:54 PST
Retargeting this defect to one java script tune - JSStringBuilder which uses UString::characters() and a 16 bit buffer irrespective of the actual string size or data range.
Michael Saboff
Comment 2 2011-11-22 10:30:17 PST
Created attachment 116243 [details] Patch
Filip Pizlo
Comment 3 2011-11-24 11:05:18 PST
Comment on attachment 116243 [details] Patch What is the performance effect, if any?
Michael Saboff
Comment 4 2011-11-24 22:22:28 PST
(In reply to comment #3) > (From update of attachment 116243 [details]) > What is the performance effect, if any? This patch is worth about .5% on SunSpider using jsc.
Michael Saboff
Comment 5 2011-11-24 22:23:36 PST
Committed r101147: <http://trac.webkit.org/changeset/101147>
Note You need to log in before you can comment on or make changes to this bug.