iframe fails to scroll in composited page

• Component: Layout and Rendering
• Status: RESOLVED FIXED

[Vangelis Kokkevis]

This was reported in:http://code.google.com/p/chromium/issues/detail?id=103250

To reproduce:
1. Go to http://dl.dropbox.com/u/671766/chromecanvasbug/testcanvas.html
2. Try to scroll the inner scrollable iframe. It should scroll fine.
3. Open the inspector and find the canvas element. Add a -webkit-transform:translateZ(0) to it.
4. Try to scroll the inner scrollable iframe again.  The scrollbar moves but the contents won't update.


This repros in Chrome 17, Safari 5 and WebKit nightly r100547

[Adrienne Walker]

Created attachment 118860 [details]
Patch

[Simon Fraser (smfr)]

Comment on attachment 118860 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=118860&action=review

> Source/WebCore/page/FrameView.cpp:1548
> +        LayoutRect rect(frameRenderer->borderLeft() + frameRenderer->paddingLeft(),
> +                        frameRenderer->borderTop() + frameRenderer->paddingTop(),
> +                        frameView->visibleWidth(), frameView->visibleHeight());
> +        frameRenderer->repaintRectangle(rect);

It's not clear that this rect math works correctly if there's a CSS transform between this frame view and the one doing the repainting.

[Adrienne Walker]

Created attachment 118915 [details]
Add a transform to the test

[Adrienne Walker]

Comment on attachment 118915 [details]
Add a transform to the test

Er, ignore this patch.  Sorry.

[Simon Fraser (smfr)]

Comment on attachment 118915 [details]
Add a transform to the test

View in context: https://bugs.webkit.org/attachment.cgi?id=118915&action=review

> Source/WebCore/page/FrameView.cpp:1550
> +            FloatPoint absoluteLocation = thisOwnerRenderer->localToAbsolute(rect.location(), false, true);
> +            rect.setLocation(roundedIntPoint(frameRenderer->absoluteToLocal(absoluteLocation, false, true)));

I think you should use Widget::convertToContainingView() here.

[Adrienne Walker]

Created attachment 118922 [details]
Greatly simplify

[Adrienne Walker]

(In reply to comment #6)
> Created an attachment (id=118922) [details]
> Greatly simplify

It looks like repaintRectangle on the inner iframe renderer ends up converting to the right space.  That seems simpler than doing the conversion manually.

[WebKit Review Bot]

Comment on attachment 118922 [details]
Greatly simplify

Clearing flags on attachment: 118922

Committed r102649: <http://trac.webkit.org/changeset/102649>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.