Summary: | Disable deprecation warnings around code where we cannot easily switch away from the deprecated APIs. | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Mark Rowe (bdash) <mrowe> | ||||||
Component: | WebKit Misc. | Assignee: | Mark Rowe (bdash) <mrowe> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | ||||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Mark Rowe (bdash)
2011-11-17 13:13:29 PST
Created attachment 115665 [details]
Patch v1
Patch!
Comment on attachment 115665 [details]
Patch v1
Should we do this in other files where we currently disable the warning for the entire file?
In most cases, yes. Rolled out in r100703 because apparently our SnowLeopard bots are still using Xcode 3.2.6 and thus are building WebCore with GCC… which is unhappy with some of the "#pragma GCC diagnostic" stuff. I think upgrading the bots to a less ancient version of Xcode may be the best solution. I’ll look in to that tomorrow. Created attachment 115999 [details]
Patch v2
This switches to using “#pragma diagnostic clang” wrapped in “#if COMPILER(CLANG)” since push / pop don’t work for GCC anyway. The fact it won’t have any effect on GCC doesn’t matter since GCC isn’t a supported compiler for WebKit on anything newer than SnowLeopard.
|