Bug 72641 – Appearance of compound transform animations under apps linked on SnowLeopard is incorrect

• Component: New Bugs
• Status: RESOLVED FIXED

[Simon Fraser (smfr)]

Appearance of compound transform animations under apps linked on SnowLeopard is incorrect

[Simon Fraser (smfr)]

Created attachment 115650 [details]
Patch

[Simon Fraser (smfr)]

<rdar://problem/10314267>

[Radar WebKit Bug Importer]

<rdar://problem/10464304>

[Chris Marrin]

Comment on attachment 115650 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=115650&action=review

Generally looks good. But it needs at least a test that proves the ordering is right. You should also check to make sure our additive animation tests are sufficient, since you're making substantive changes to how you do additive.

> Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp:1746
> +#if !defined(BUILDING_ON_SNOW_LEOPARD) && !PLATFORM(WIN)

So this is code is going to compile in on Leopard and then on Lion and above?

[Dean Jackson]

Comment on attachment 115650 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=115650&action=review

>> Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp:1746
>> +#if !defined(BUILDING_ON_SNOW_LEOPARD) && !PLATFORM(WIN)
> 
> So this is code is going to compile in on Leopard and then on Lion and above?

Unless BUILDING_ON_SNOW_LEOPARD includes LION, which would be weird but not completely unexpected.

[Simon Fraser (smfr)]

Created attachment 115715 [details]
Patch

[Simon Fraser (smfr)]

(In reply to comment #5)
> (From update of attachment 115650 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=115650&action=review
> 
> >> Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp:1746
> >> +#if !defined(BUILDING_ON_SNOW_LEOPARD) && !PLATFORM(WIN)
> > 
> > So this is code is going to compile in on Leopard and then on Lion and above?

We don't care about Leopard. "reverse" defaults to true. On Lion and later, we do the link check, and flip the flag to false.

[WebKit Review Bot]

Attachment 115715 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/update-webkit']" exit_code: 9

Updating OpenSource
From git://git.webkit.org/WebKit
   64d810f..f0128e0  master     -> origin/master
Partial-rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc ...
Currently at 100705 = e5736d6fce89243607b7cf5020c3bf9a52db4d2f
r100704 = 7d7b005933e515a913b90d458ca908b44130576d
r100705 = 0921df4d01122e7d31bcbabffb7c4de478c3914a
r100706 = 71cc4ad1d79ed791b8f3d640f39ee76cb34bc76d
r100707 = 89b4a32720da4e02761395a199d4a75823f8890c
r100708 = f0128e0e343dd0913ba23758dc1fb19639b9da9c
Done rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc
RA layer request failed: OPTIONS of 'http://svn.webkit.org/repository/webkit': could not connect to server (http://svn.webkit.org) at /usr/lib/git-core/git-svn line 2295

Died at Tools/Scripts/update-webkit line 157.


If any of these errors are false positives, please file a bug against check-webkit-style.

[Dean Jackson]

Comment on attachment 115715 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=115715&action=review

> Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp:1748
> +#if !defined(BUILDING_ON_SNOW_LEOPARD) && !PLATFORM(WIN)
> +        // Old versions of Core Animation apply animations in reverse order (<rdar://problem/7095638>) so we need to flip the list.
>          // to be non-additive. For binary compatibility, the current version of Core Animation preserves this behavior for applications linked

Unless my diff decoding is faulty, you've got a "to be non-additive" empty sentence there, or an extra period on the line before.

[WebKit Review Bot]

Comment on attachment 115715 [details]
Patch

Attachment 115715 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/10511522

New failing tests:
animations/3d/additive-transform-animations.html

[Simon Fraser (smfr)]

http://trac.webkit.org/changeset/100800