| Summary: | CSS 2.1 failure: empty-inline-003.htm fails | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Robert Hogan <robert> | ||||||||
| Component: | CSS | Assignee: | Robert Hogan <robert> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | dglazkov, hyatt, mitz, rniwa, robert, webkit.review.bot | ||||||||
| Priority: | P2 | ||||||||||
| Version: | 528+ (Nightly build) | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| URL: | http://test.csswg.org/suites/css2.1/20101027/html4/empty-inline-003.htm | ||||||||||
| Bug Depends on: | |||||||||||
| Bug Blocks: | 47141 | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Robert Hogan
2011-11-17 11:59:35 PST
Created attachment 115656 [details]
Patch
Comment on attachment 115656 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=115656&action=review > Source/WebCore/ChangeLog:10 > + going to affect the line-height. Don't think we normally indent the comment like this. Created attachment 115984 [details]
Patch
Comment on attachment 115984 [details] Patch Attachment 115984 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/10342078 New failing tests: platform/chromium-linux/fast/text/international/complex-joining-using-gpos.html Comment on attachment 115984 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=115984&action=review Per IRC discussion, some of these tests are modified from CSS2.1 test suite so they should be added to fast/css. > Source/WebCore/ChangeLog:8 > + Reviewed by NOBODY (OOPS!). This line should appear before the description. Created attachment 116109 [details]
Patch
Comment on attachment 116109 [details]
Patch
Looks sane to me. You may consider using Ahem for fast/css tests.
Committed r100949: <http://trac.webkit.org/changeset/100949> |