Summary: | [Qt] REGRESSION(r100510): Enable 8 Bit Strings in JavaScriptCore | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Gabor Loki <loki> | ||||
Component: | WebCore JavaScript | Assignee: | Michael Saboff <msaboff> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | ggaren, msaboff, ossy, zherczeg | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | All | ||||||
OS: | Linux | ||||||
Attachments: |
|
Description
Gabor Loki
2011-11-17 04:54:12 PST
The tests were skipped in http://trac.webkit.org/changeset/100608 These tests work fine on Mac. The problem appears to be in WebCore/editing/TextIterator.cpp when WTF_USE_ICU_UNICODE is 0. Continuing to investigate. Created attachment 115643 [details]
Proposed Patch
I debugged and fixed this issue on a Mac by locally disabling WTF_USE_ICU_UNICODE in WebCore/editing/TextIterator.cpp. The proposed patch fixed the issues, but the expected results for the impacted tests as well as a few others are different on Mac than on qt. Therefore I'd like someone working on qt to verify that this does fix the test failures in a qt build.
> Created an attachment (id=115643) [details]
You are great! I can confirm that the patch fixes those tests.
Thank you very much!
(In reply to comment #4) > > Created an attachment (id=115643) [details] [details] > > You are great! I can confirm that the patch fixes those tests. > Thank you very much! Do you want me to add the changes to relabel the skipped tests? If you have time to create another patch which relabels those tests as well, please do it. Otherwise I will take care of them tomorrow. Thanks again! Comment on attachment 115643 [details]
Proposed Patch
rs=me
Comment on attachment 115643 [details] Proposed Patch Landed in http://trac.webkit.org/changeset/100729 The tests are enabled in http://trac.webkit.org/changeset/100730 |