Bug 72575

Summary: Add finalizer to JSActivation
Product: WebKit Reporter: Mark Hahnenberg <mhahnenberg>
Component: JavaScriptCoreAssignee: Mark Hahnenberg <mhahnenberg>
Status: RESOLVED FIXED    
Severity: Normal CC: webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Bencher results none

Mark Hahnenberg
Reported 2011-11-16 18:30:57 PST
We want to start to transition virtual destructors in the JSCell hierarchy to finalizers. JSActivation has a virtual destructor.
Attachments
Patch (2.34 KB, patch)
2011-11-16 18:33 PST, Mark Hahnenberg 		no flags
DetailsFormatted DiffDiff
Bencher results (6.81 KB, text/plain)
2011-11-16 18:38 PST, Mark Hahnenberg 		no flags
Details
View All Add attachment proposed patch, testcase, etc.
Mark Hahnenberg
Comment 1 2011-11-16 18:33:02 PST
Created attachment 115508 [details] Patch
Mark Hahnenberg
Comment 2 2011-11-16 18:38:48 PST
Created attachment 115510 [details] Bencher results Neutral on SunSpider and V8, ~0.3% win on kraken.
Geoffrey Garen
Comment 3 2011-11-17 11:20:09 PST
Comment on attachment 115508 [details] Patch r=me
WebKit Review Bot
Comment 4 2011-11-17 14:04:26 PST
Comment on attachment 115508 [details] Patch Clearing flags on attachment: 115508 Committed r100672: <http://trac.webkit.org/changeset/100672>
WebKit Review Bot
Comment 5 2011-11-17 14:04:30 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.