Bug 72568

Summary: bool WebChromeClient::shouldInterruptJavaScript casts pointer to bool and always returns true
Product: WebKit Reporter: Anton D'Auria <adauria>
Component: WebKit APIAssignee: Anton D'Auria <adauria>
Status: RESOLVED FIXED    
Severity: Normal CC: aroben, ddkilzer, ggaren, joepeck, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Anton D'Auria
Reported 2011-11-16 17:33:35 PST
bool WebChromeClient::shouldInterruptJavaScript() uses CallUIDelegate instead of CallUIDelegateReturningBoolean. This causes shouldInterruptJavaScript() to cast a pointer to a bool, thereby always returning true.
Attachments
Patch (1.62 KB, patch)
2011-11-17 11:28 PST, Anton D'Auria 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Anton D'Auria
Comment 1 2011-11-17 11:28:48 PST
Created attachment 115629 [details] Patch
David Kilzer (:ddkilzer)
Comment 2 2011-11-18 06:08:35 PST
Comment on attachment 115629 [details] Patch R=me=me
Geoffrey Garen
Comment 3 2011-11-18 10:45:31 PST
r=me too!
WebKit Review Bot
Comment 4 2011-11-18 10:58:18 PST
Comment on attachment 115629 [details] Patch Clearing flags on attachment: 115629 Committed r100792: <http://trac.webkit.org/changeset/100792>
WebKit Review Bot
Comment 5 2011-11-18 10:58:23 PST
All reviewed patches have been landed. Closing bug.
Adam Roben (:aroben)
Comment 6 2011-11-18 11:13:42 PST
It should be possible to write a regression test for this using TestWebKitAPI.
Note You need to log in before you can comment on or make changes to this bug.