Summary: | label attribute in option elements is ignored | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | John Sullivan <sullivan> | ||||||||
Component: | Forms | Assignee: | John Sullivan <sullivan> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | ||||||||||
Priority: | P2 | ||||||||||
Version: | 412 | ||||||||||
Hardware: | Mac | ||||||||||
OS: | OS X 10.4 | ||||||||||
Attachments: |
|
Description
John Sullivan
2006-02-14 12:14:14 PST
Created attachment 6487 [details]
test cases that include empty label
Created attachment 6488 [details]
patch to support label attribute for OPTION elements
Comment on attachment 6488 [details]
patch to support label attribute for OPTION elements
Oops, I didn't mean to mark it review-+. Also, I haven't attached the layout tests yet, so I'll set this to review- until I have the tests ready.
Created attachment 6489 [details]
layout tests for patch
Comment on attachment 6488 [details]
patch to support label attribute for OPTION elements
Now that I've attached the new layout tests, this is ready for review.
HTML also will let you write: <option label>Foo</option> Should make sure we match WinIE in that situation too. Also, what about list boxes? Need to see if label is used for <select size="10"> for example. Also need to test optgroups. In response to comment 6: the behavior for this case is the same on MacIE as in WebKit; I'll add a layout test. In response to comment 7: list boxes don't use the label but should; I'll write a bug In response to comment 8: optgroups already deal with the label (used as hierarchical menu item title) I was wrong about list boxes in my previous comment; they do work correctly now with label attributes. (I was using the wrong Safari when I tested that case.) I'm adding another layout test for this. |