Bug 72537 – Add API for paginated display

• Component: WebKit API
• Status: RESOLVED FIXED

Add API for paginated display

<rdar://problem/10262242>

Created attachment 115434 [details]
Add WebKit1 Mac SPI, WebKit2 Mac SPI and WebKit2 C SPI

[WebKit Review Bot]

Attachment 115434 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1

Source/WebKit2/UIProcess/API/mac/WKBrowsingContextControllerPrivate.h:35:  Extra space before ( in function call  [whitespace/parens] [4]
Total errors found: 1 in 22 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Sam Weinig]

Comment on attachment 115434 [details]
Add WebKit1 Mac SPI, WebKit2 Mac SPI and WebKit2 C SPI

View in context: https://bugs.webkit.org/attachment.cgi?id=115434&action=review

> Source/WebKit2/UIProcess/API/C/WKPagePrivate.h:64
> +WK_EXPORT void WKPageSetGapBetweenPages(WKPageRef page, double gap);

What units is this gap in? Pixels?

(In reply to comment #4)
> (From update of attachment 115434 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=115434&action=review
> 
> > Source/WebKit2/UIProcess/API/C/WKPagePrivate.h:64
> > +WK_EXPORT void WKPageSetGapBetweenPages(WKPageRef page, double gap);
> 
> What units is this gap in? Pixels?

They are document view units (i.e. they are scaled by the page scale factor).

[Anders Carlsson]

Comment on attachment 115434 [details]
Add WebKit1 Mac SPI, WebKit2 Mac SPI and WebKit2 C SPI

View in context: https://bugs.webkit.org/attachment.cgi?id=115434&action=review

> Source/WebKit2/Shared/WebPageCreationParameters.cpp:49
> +    encoder->encode(paginationMode);

You can just use encodeEnum here.

> Source/WebKit2/Shared/WebPageCreationParameters.cpp:96
> +    if (!decoder->decode(parameters.paginationMode))
> +        return false;

and decodeEnum here.

Committed <http://trac.webkit.org/r100534>.