Summary: | [GTK] Consider parent AtkObject in webkit_accessible_get_parent(), if already set | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Mario Sanchez Prada <mario> | ||||||
Component: | WebKitGTK | Assignee: | Nobody <webkit-unassigned> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | cgarcia, mrobinson | ||||||
Priority: | P2 | Keywords: | Gtk | ||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Bug Depends on: | |||||||||
Bug Blocks: | 72588 | ||||||||
Attachments: |
|
Description
Mario Sanchez Prada
2011-11-16 11:00:26 PST
Created attachment 115411 [details]
Patch proposal + unit test
Patch implementing the idea explained before, plus an unit test to prove that it actually makes a difference :-)
This blocks a11y support in WebKit2GTK+ Comment on attachment 115411 [details] Patch proposal + unit test View in context: https://bugs.webkit.org/attachment.cgi?id=115411&action=review > Source/WebKit/gtk/tests/testatk.c:1669 > + g_assert(atk_object_get_parent(axRoot) == axButton); I think it would be useful to expand the test a bit: - Add the view to an offscreen window. Get the parent. Should be the window. - Now set_parent to the button, like you do now. Now get_parent should be the button, not the window. Hope that makes sense, that way we check the base case works and that the transition happens correctly. Looks good to me otherwise! Created attachment 115545 [details]
Patch proposal + unit test
New patch addressing the issues commented by Xan
Comment on attachment 115545 [details]
Patch proposal + unit test
r=me
Committed r100597: <http://trac.webkit.org/changeset/100597> |