Summary: | [Qt] Move WebKit2 C++ APIs to private API and build QML extension plugin on top of that | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Tor Arne Vestbø <vestbo> | ||||
Component: | New Bugs | Assignee: | Tor Arne Vestbø <vestbo> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | cmarcelo, hausmann, kenneth, menard, webkit.review.bot, zoltan | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Tor Arne Vestbø
2011-11-16 10:35:49 PST
Hey why not use 20 sec and actually upload the patch? (In reply to comment #2) > Hey why not use 20 sec and actually upload the patch? Cause webkit-patch still hates me :/ Please enter a bug number or a title for a new bug: [Qt] Move WebKit2 C++ APIs to private API and build QML extension plugin on top of that Reading Keychain for bugs.webkit.org account and password. Click "Allow" to continue... Logging in as vestbo@webkit.org... Creating bug with title "[Qt] Move WebKit2 C++ APIs to private API and build QML extension plugin on top of that" Bug 72522 created. https://bugs.webkit.org/show_bug.cgi?id=72522 Fetching: https://bugs.webkit.org/show_bug.cgi?id=72522&ctype=xml Running status to find changed, added, or removed files. Reviewing diff to determine which lines changed. Extracting affected function names from source files. Traceback (most recent call last): File "/Users/torarne/dev/webkit/wip/Tools/scripts/webkit-patch", line 74, in <module> main() File "/Users/torarne/dev/webkit/wip/Tools/scripts/webkit-patch", line 69, in main WebKitPatch(os.path.abspath(__file__)).main() File "/Users/torarne/dev/webkit/wip/Tools/Scripts/webkitpy/tool/multicommandtool.py", line 308, in main result = command.check_arguments_and_execute(options, args, self) File "/Users/torarne/dev/webkit/wip/Tools/Scripts/webkitpy/tool/multicommandtool.py", line 117, in check_arguments_and_execute return self.execute(options, args, tool) or 0 File "/Users/torarne/dev/webkit/wip/Tools/Scripts/webkitpy/tool/commands/abstractsequencedcommand.py", line 51, in execute self._sequence.run_and_handle_errors(tool, options, state) File "/Users/torarne/dev/webkit/wip/Tools/Scripts/webkitpy/tool/commands/stepsequence.py", line 70, in run_and_handle_errors self._run(tool, options, state) File "/Users/torarne/dev/webkit/wip/Tools/Scripts/webkitpy/tool/commands/stepsequence.py", line 64, in _run step(tool, options).run(state) File "/Users/torarne/dev/webkit/wip/Tools/Scripts/webkitpy/tool/steps/preparechangelog.py", line 76, in run self._tool.executive.run_and_throw_if_fail(args, self._options.quiet, cwd=self._tool.scm().checkout_root) File "/Users/torarne/dev/webkit/wip/Tools/Scripts/webkitpy/common/system/executive.py", line 147, in run_and_throw_if_fail exit_code = self._run_command_with_teed_output(args, child_stdout, cwd=cwd) File "/Users/torarne/dev/webkit/wip/Tools/Scripts/webkitpy/common/system/executive.py", line 132, in _run_command_with_teed_output teed_output.write(output_line) File "/Users/torarne/dev/webkit/wip/Tools/Scripts/webkitpy/common/system/deprecated_logging.py", line 55, in write file.write(bytes) File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/codecs.py", line 351, in write data, consumed = self.encode(object, self.errors) UnicodeDecodeError: 'ascii' codec can't decode byte 0xc3 in position 31: ordinal not in range(128) webkit-patch upload -g HEAD 1.93s user 0.25s system 6% cpu 32.988 total Created attachment 115552 [details]
Patch
Comment on attachment 115552 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=115552&action=review r=me but fix the coding style before landing :) > Source/WebKit/qt/declarative/experimental/plugin.cpp:33 > + QQuickWebViewExperimentalExtension(QObject *parent = 0) : QObject(parent) { } > + QQuickWebViewExperimental* experimental() { return static_cast<QQuickWebView*>(parent())->experimental(); } Coding style: Move the braces onto lines of their own. |