Bug 72492

Summary:

HTMLAllCollection bindings should inherit from HTMLCollection.

Product:

WebKit

Reporter:

Andreas Kling <kling>

Component:

WebCore JavaScript

Assignee:

Andreas Kling <kling>

Status:

RESOLVED INVALID

Severity:

Normal

CC:

abarth, arv, cdumez, dglazkov, japhet, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Proposed patch	webkit.review.bot: commit-queue-
Proposed patch v2	webkit.review.bot: commit-queue-

Andreas Kling

Reported 2011-11-16 05:32:18 PST

HTMLAllCollection inherits from HTMLCollection in current HTML5. Doing this in WebKit would allow us to get rid of some duplicated code.

Attachments
Proposed patch (6.99 KB, patch) 2011-11-16 05:50 PST, Andreas Kling	webkit.review.bot: commit-queue-	Details Formatted Diff Diff
Proposed patch v2 (6.46 KB, patch) 2011-11-16 05:59 PST, Andreas Kling	webkit.review.bot: commit-queue-	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Andreas Kling

Comment 1 2011-11-16 05:50:38 PST

WebKit Review Bot

Comment 2 2011-11-16 05:55:11 PST

Andreas Kling

Comment 3 2011-11-16 05:59:56 PST

Created attachment 115363 [details] Proposed patch v2

WebKit Review Bot

Comment 4 2011-11-16 06:50:30 PST

Comment on attachment 115363 [details] Proposed patch v2 Attachment 115363 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/10487725 New failing tests: fast/dom/collection-null-like-arguments.html fast/dom/document-all-input.html fast/dom/document-all-select.html inspector/console/console-format-collections.html

Andreas Kling

Comment 5 2011-11-16 08:38:35 PST

Comment on attachment 115363 [details] Proposed patch v2 Clearing r?, will investigate the cr failures.

Chris Dumez

Comment 6 2017-07-18 08:50:24 PDT

Note You need to log in before you can comment on or make changes to this bug.