Bug 72488

Summary: Remove unnecessary if check from RenderListBox::paintItemForeground
Product: WebKit Reporter: Antaryami Pandia <xqb748>
Component: WebCore Misc.Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: darin, tkent, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Linux   
Attachments:
Description Flags
Proposed Patch none

Antaryami Pandia
Reported 2011-11-16 04:35:48 PST
There is a if check which checks for visibility before drawing text. if (itemStyle->visibility() != HIDDEN) paintInfo.context->drawBidiText(itemFont, textRun, r.location()); I think this if check is unnecessary, since there is already an early return available for the visibility and the itemStyle is not modified in between. The early return is as follows:- if (itemStyle->visibility() == HIDDEN) return;
Attachments
Proposed Patch (1.26 KB, patch)
2011-11-16 04:40 PST, Antaryami Pandia 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Antaryami Pandia
Comment 1 2011-11-16 04:40:58 PST
Created attachment 115359 [details] Proposed Patch Proposed Patch.
Andreas Kling
Comment 2 2011-11-16 06:19:15 PST
Comment on attachment 115359 [details] Proposed Patch r=me
WebKit Review Bot
Comment 3 2011-11-16 07:05:13 PST
Comment on attachment 115359 [details] Proposed Patch Clearing flags on attachment: 115359 Committed r100447: <http://trac.webkit.org/changeset/100447>
WebKit Review Bot
Comment 4 2011-11-16 07:05:17 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.