Bug 72487

Summary: Compositing LayoutTests failing on Chromium Mac
Product: WebKit Reporter: Steve Block <steveblock>
Component: WebCore Misc.Assignee: James Robinson <jamesr>
Status: RESOLVED FIXED    
Severity: Normal CC: jamesr, shadi, steveblock
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   

Description Steve Block 2011-11-16 04:28:55 PST
layers-inside-overflow-scroll.html overflow-compositing-descendant.html scroll-ancestor-update.html self-painting-layers.html 

See http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=compositing%2Flayers-inside-overflow-scroll.html%2Ccompositing%2Foverflow%2Foverflow-compositing-descendant.html%2Ccompositing%2Foverflow%2Fscroll-ancestor-update.html%2Ccompositing%2Fself-painting-layers.html

From the time that the failures started, it looks like this is due to http://trac.webkit.org/changeset/100360, perhaps due to unexpected fallback paths for expected results?
Comment 1 Steve Block 2011-11-16 04:34:31 PST
Committed r100430: <http://trac.webkit.org/changeset/100430>
Comment 2 James Robinson 2011-11-16 21:09:19 PST
They just needed baselines: http://trac.webkit.org/changeset/100557
Comment 3 Steve Block 2011-11-17 03:39:10 PST
Some tests are still failing on 10.6 ...

compositing/layer-creation/spanOverlapsCanvas.html
compositing/layers-inside-overflow-scroll.html
compositing/self-painting-layers.html
compositing/video-page-visibility.html
compositing/geometry/video-opacity-overlay.html
compositing/geometry/video-fixed-scrolling.html
compositing/geometry/clipped-video-controller.html
compositing/overflow/scroll-ancestor-update.html
compositing/overflow/overflow-compositing-descendant.html

http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=compositing%2Flayer-creation%2FspanOverlapsCanvas.html%2Ccompositing%2Fgeometry%2Fclipped-video-controller.html%2Ccompositing%2Fgeometry%2Fvideo-fixed-scrolling.html%2Ccompositing%2Fgeometry%2Fvideo-opacity-overlay.html%2Ccompositing%2Flayers-inside-overflow-scroll.html%2Ccompositing%2Foverflow%2Foverflow-compositing-descendant.html%2Ccompositing%2Foverflow%2Fscroll-ancestor-update.html%2Ccompositing%2Fself-painting-layers.html%2Ccompositing%2Fvideo-page-visibility.html
Comment 4 Steve Block 2011-11-17 03:53:55 PST
Committed r100598: <http://trac.webkit.org/changeset/100598>
Comment 5 Shadi 2011-11-17 19:32:00 PST
These tests are still failing:
compositing/geometry/video-opacity-overlay.html
compositing/geometry/video-fixed-scrolling.html
compositing/overflow/overflow-compositing-descendant.html
compositing/self-painting-layers.html
compositing/overflow/scroll-ancestor-update.html 
compositing/geometry/clipped-video-controller.html

Were the baselines wrong?
Comment 6 James Robinson 2011-11-17 20:01:07 PST
'598 just added expectations, not baselines. It looks like some of these (at least compositing/geometry/video-opacity-overlay.html) are in fact rendering correctly but need a rebaseline. They've been somewhat unstable lately because of recent configuration changes which changed the tests from using the software video path to using H/W colorspace conversion and scaling, which very slightly changes the video's display.
Comment 7 Shadi 2011-11-18 12:59:45 PST
As far as I can tell, they all seem to just need a rebaseline.

Steve/James, can you please verify that and submit new baselines? 

Thanks!
Comment 8 Steve Block 2011-11-21 09:50:58 PST
I filed the bug as WebKit gardener - leaving to James to confirm as I think he's the owner of these tests.
Comment 9 James Robinson 2011-11-21 12:42:14 PST
http://trac.webkit.org/changeset/100866