Bug 72416

Summary: Leaks seen in MemoryPressureHandlerMac.mm on Leaks bot
Product: WebKit Reporter: Adam Roben (:aroben) <aroben>
Component: PlatformAssignee: Michael Saboff <msaboff>
Status: RESOLVED FIXED    
Severity: Normal CC: darin, msaboff, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Mac (Intel)   
OS: OS X 10.7   
URL: http://build.webkit.org/LeaksViewer/?url=%2Fresults%2FLion%20Intel%20Leaks%2Fr100308%20%28129%29%2F
Attachments:
Description Flags
Proposed Patch ggaren: review+

Description Adam Roben (:aroben) 2011-11-15 14:10:55 PST 
http://build.webkit.org/LeaksViewer/?url=%2Fresults%2FLion%20Intel%20Leaks%2Fr100308%20%28129%29%2F shows that _cache_event_source and _timer_event_source in MemoryPressureHandlerMac.mm are being leaked.

It looks like MemoryPressureHandler::uninstall is canceling but not releasing _cache_event_source.

It looks like MemoryPressureHandler::holdOff will overwrite _timer_event_source without canceling or releasing it. (Perhaps uninstall should be doing this?)
Comment 1 Radar WebKit Bug Importer 2011-11-15 14:11:09 PST 
<rdar://problem/10450686>
Comment 2 Michael Saboff 2011-11-17 13:58:48 PST 
Created attachment 115670 [details]
Proposed Patch
Comment 3 Geoffrey Garen 2011-11-17 14:00:46 PST 
Comment on attachment 115670 [details]
Proposed Patch

r=me
Comment 4 Michael Saboff 2011-11-17 14:49:46 PST 
Committed r100681: <http://trac.webkit.org/changeset/100681>