Bug 72407

Summary: [Qt][Wk2] Add an API test for scroll request from javascript
Product: WebKit Reporter: Dinu Jacob <dinu.jacob>
Component: WebKit QtAssignee: Dinu Jacob <dinu.jacob>
Status: RESOLVED FIXED    
Severity: Normal CC: webkit.review.bot, zoltan
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch none

Dinu Jacob
Reported 2011-11-15 13:02:53 PST
API test for scroll request from Javascript in QQuickWebView.
Attachments
patch (12.31 KB, patch)
2011-11-15 13:15 PST, Dinu Jacob 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Dinu Jacob
Comment 1 2011-11-15 13:05:33 PST
I developed this patch for the previous QTouchWebView with support for scrollRequest there. As QTouchWebView no longer exists, I have added the API test I added to the new QQuickWebView tests.
Dinu Jacob
Comment 2 2011-11-15 13:15:25 PST
Created attachment 115225 [details] patch
Simon Hausmann
Comment 3 2011-11-18 00:10:06 PST
Comment on attachment 115225 [details] patch Why not :)
Kenneth Rohde Christiansen
Comment 4 2011-11-18 00:18:34 PST
Comment on attachment 115225 [details] patch A scrolling test should also apply a scale and then scroll and it should in theory also test scroll requests coming from session history.
Dinu Jacob
Comment 5 2011-11-18 14:46:03 PST
(In reply to comment #4) > (From update of attachment 115225 [details]) > A scrolling test should also apply a scale and then scroll and it should in theory also test scroll requests coming from session history. Can add that as another patch as this one was intended to take care of scroll request from javascript (the implementation of which was not there in the old QTouchWebView)
WebKit Review Bot
Comment 6 2011-11-18 15:01:47 PST
Comment on attachment 115225 [details] patch Clearing flags on attachment: 115225 Committed r100816: <http://trac.webkit.org/changeset/100816>
WebKit Review Bot
Comment 7 2011-11-18 15:01:51 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.