Bug 72348

Summary:

DFG::SpeculativeJIT and DFG::JITCodeGenerator should be combined

Product:

WebKit

Reporter:

Filip Pizlo <fpizlo>

Component:

JavaScriptCore

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

gustavo.noronha, gustavo, webkit.review.bot, xan.lopez

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Bug Depends on:

Bug Blocks:

72347

Attachments:

Description	Flags
the patch	gyuyoung.kim: commit-queue-
the patch	barraclough: review+, webkit-ews: commit-queue-

Filip Pizlo

Reported 2011-11-14 20:15:50 PST

The separation between these two classes made sense when there was a DFG:NonSpeculativeJIT. But there isn't one anymore, and the separation is getting in the way of further progress.

Attachments
the patch (435.39 KB, patch) 2011-11-14 20:34 PST, Filip Pizlo	gyuyoung.kim: commit-queue-	Details Formatted Diff Diff
the patch (436.29 KB, patch) 2011-11-14 20:41 PST, Filip Pizlo	barraclough: review+ webkit-ews: commit-queue-	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Filip Pizlo

Comment 1 2011-11-14 20:17:00 PST

This blocks https://bugs.webkit.org/show_bug.cgi?id=72347 because that bug requires that the appendCallWithXYZ methods know about speculation checks. Those methods are currently in JITCodeGenerator. It's probably best if we just move everything out of JITCodeGenerator and into SpeculativeJIT.

Filip Pizlo

Comment 2 2011-11-14 20:34:54 PST

Created attachment 115090 [details] the patch

WebKit Review Bot

Comment 3 2011-11-14 20:37:31 PST

Attachment 115090 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/fast/js/script-tests/dfg-inlin..." exit_code: 1 Source/JavaScriptCore/dfg/DFGSpeculativeJIT32_64.cpp:1285: One line control clauses should not use braces. [whitespace/braces] [4] Source/JavaScriptCore/dfg/DFGSpeculativeJIT.h:1877: Missing space inside { }. [whitespace/braces] [5] Total errors found: 2 in 7 files If any of these errors are false positives, please file a bug against check-webkit-style.

Gyuyoung Kim

Comment 4 2011-11-14 20:39:32 PST

Comment on attachment 115090 [details] the patch Attachment 115090 [details] did not pass efl-ews (efl): Output: http://queues.webkit.org/results/10486195

Collabora GTK+ EWS bot

Comment 5 2011-11-14 20:40:38 PST

Comment on attachment 115090 [details] the patch Attachment 115090 [details] did not pass gtk-ews (gtk): Output: http://queues.webkit.org/results/10484184

Filip Pizlo

Comment 6 2011-11-14 20:41:28 PST

Created attachment 115091 [details] the patch Fixed some build systems. Fixed style. Fixed a merge goof where my previous patch was removing some LayoutTest.

Early Warning System Bot

Comment 7 2011-11-14 22:58:46 PST

Comment on attachment 115091 [details] the patch Attachment 115091 [details] did not pass qt-ews (qt): Output: http://queues.webkit.org/results/10485233

Filip Pizlo

Comment 8 2011-11-14 23:04:25 PST

Landed in http://trac.webkit.org/changeset/100244

Filip Pizlo

Comment 9 2011-11-14 23:05:00 PST

(In reply to comment #7) > (From update of attachment 115091 [details]) > Attachment 115091 [details] did not pass qt-ews (qt): > Output: http://queues.webkit.org/results/10485233 I'm assuming this was just due to JSValueOperand not being forward-declared in SpeculativeJIT.h. Watching the bots to make sure this is the case...

Note You need to log in before you can comment on or make changes to this bug.