Bug 72301
| Summary: | Web Inspector: WebInspector.notifications should not be defined in Object.js | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Timothy Hatcher <timothy> |
| Component: | Web Inspector (Deprecated) | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED INVALID | ||
| Severity: | Normal | CC: | apavlov, bweinstein, joepeck, keishi, loislo, pfeldman, pmuellr, rik, yurys |
| Priority: | P2 | ||
| Version: | 528+ (Nightly build) | ||
| Hardware: | All | ||
| OS: | All | ||
Timothy Hatcher
I was surprised to see WebInspector.notifications defined in Object.js. It hould be defined in inspector.js or somewhere else. The Object.js file has nothing to do with a global notification system and putting it in this file is not correct.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Timothy Hatcher
It looks like WorkerManager is the only client of this, and it is adding a listener. There is no client dispatching events to WebInspector.notifications that I could find!
Just remove WebInspector.notifications?
Brian Burg
Closing as invalid, as this bug pertains to the old inspector UI and/or its tests.
Please file a new bug (https://www.webkit.org/new-inspector-bug) if the bug/feature/issue is still relevant to WebKit trunk.