Bug 72282
| Summary: | style checker reports "Path does not exist" for all tests | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Tony Gentilcore <tonyg> |
| Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED DUPLICATE | ||
| Severity: | Normal | CC: | abarth, dpranke, eric, hclam, reed |
| Priority: | P2 | ||
| Version: | 528+ (Nightly build) | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Tony Gentilcore
1. Make any change to LayoutTests/platform/chromium/test_expectations.txt
2. Run webkit-patch upload
Notice "Path does not exist" reported for all test files.
Example is here:
http://queues.webkit.org/results/10449563
I looked into this briefly, and it seems like the fundamental problem is that we create a Port without a Host. This causes us to raise an exception due to a None Host, hit "WARNING: Could not determine the port for LayoutTests/platform/chromium/test_expectations.txt. Using 'test' port, but platform-specific expectations will fail the check.", then use the "test" Port which has a dummy path for all tests. I couldn't immediately determine the right way to pass in a valid host and have to move on to more pressing gardening tasks.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Adam Barth
There's another bug on file about this. I think Eric broke it in one of his changes to how we find the current port.
Tony Gentilcore
*** This bug has been marked as a duplicate of bug 72275 ***
Eric Seidel (no email)
It was a small typo, which was masked by check-webkit-style using a generic try/catch block which caught all throwables. :(