Bug 72260 – Web Inspector: adapt Inspector's performance tests for running with run_webkit_test

• Component: Web Inspector (Deprecated)
• Status: RESOLVED FIXED

[Ilya Tikhonovsky]

Sample command line:
$ ./webkit/tools/layout_tests/run_webkit_tests.sh --release --no-retry-failures inspector/performance --time-out-ms=30000 --no-pixel-tests --print=performance -f --no-show-results --force

Sample output:
RESULT first-open: first-open-resources= 34 ms
RESULT first-open: heap-delta-first-open-resources= 43 kB
RESULT first-open: first-open-elements= 101 ms
RESULT first-open: heap-delta-first-open-elements= 10 kB
RESULT first-open: first-open-scripts= 158 ms
RESULT first-open: heap-delta-first-open-scripts= 160 kB
RESULT panel-switch: show-panel-elements= 20 ms
RESULT panel-switch: show-panel-resources= 11 ms
RESULT panel-switch: show-panel-network= 58 ms
RESULT panel-switch: show-panel-scripts= 33 ms
RESULT panel-switch: show-panel-timeline= 21 ms
RESULT panel-switch: show-panel-profiles= 10 ms
RESULT panel-switch: show-panel-audits= 9 ms
RESULT panel-switch: show-panel-console= 10 ms
RESULT panel-switch: heap-delta-show-panel= 1 kB
RESULT panel-update: network-append-30-requests= 53 ms
RESULT panel-update: heap-delta-network-append-30-requests= 2 kB
RESULT inspector-startup-time: time= 552 ms

[Ilya Tikhonovsky]

Created attachment 114923 [details]
[patch] initial version

[WebKit Review Bot]

Attachment 114923 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/insp..." exit_code: 1

Last 3072 characters of output:
ml  [test/expectations] [2]
LayoutTests/platform/chromium/test_expectations.txt:3862:  Path does not exist. svg/zoom/page/relative-sized-document-scrollbars.svg  [test/expectations] [2]
LayoutTests/platform/chromium/test_expectations.txt:3864:  Path does not exist. storage/indexeddb/key-type-array.html  [test/expectations] [2]
LayoutTests/platform/chromium/test_expectations.txt:3866:  Path does not exist. storage/indexeddb/factory-deletedatabase-interactions.html  [test/expectations] [2]
LayoutTests/platform/chromium/test_expectations.txt:3868:  Path does not exist. fast/js/array-functions-non-arrays.html  [test/expectations] [2]
LayoutTests/platform/chromium/test_expectations.txt:3869:  Path does not exist. fast/js/eval-cross-window.html  [test/expectations] [2]
LayoutTests/platform/chromium/test_expectations.txt:3870:  Path does not exist. fast/js/regexp-caching.html  [test/expectations] [2]
LayoutTests/platform/chromium/test_expectations.txt:3871:  Path does not exist. fast/js/toString-overrides.html  [test/expectations] [2]
LayoutTests/platform/chromium/test_expectations.txt:3872:  Path does not exist. fast/js/toString-recursion.html  [test/expectations] [2]
LayoutTests/platform/chromium/test_expectations.txt:3873:  Path does not exist. http/tests/security/xss-eval.html  [test/expectations] [2]
LayoutTests/platform/chromium/test_expectations.txt:3875:  Path does not exist. fast/dom/javascript-url-exception-isolation.html  [test/expectations] [2]
LayoutTests/platform/chromium/test_expectations.txt:3876:  Path does not exist. fast/borders/inline-mask-overlay-image-outset-vertical-rl.html  [test/expectations] [2]
LayoutTests/platform/chromium/test_expectations.txt:3878:  Path does not exist. fast/dom/rtl-scroll-to-leftmost-and-resize.html  [test/expectations] [2]
LayoutTests/platform/chromium/test_expectations.txt:3880:  Path does not exist. accessibility/adjacent-continuations-cause-assertion-failure.html  [test/expectations] [2]
LayoutTests/platform/chromium/test_expectations.txt:3882:  Path does not exist. inspector/debugger/script-formatter.html  [test/expectations] [2]
LayoutTests/platform/chromium/test_expectations.txt:3885:  Path does not exist. fast/js/mozilla/strict/15.4.5.1.html  [test/expectations] [2]
LayoutTests/platform/chromium/test_expectations.txt:3887:  Path does not exist. fast/canvas/canvas-transforms-fillRect-shadow.html  [test/expectations] [2]
LayoutTests/platform/chromium/test_expectations.txt:3889:  Path does not exist. media/track/tracklist-is-reachable.html  [test/expectations] [2]
LayoutTests/platform/chromium/test_expectations.txt:3891:  Path does not exist. http/tests/inspector-enabled/dedicated-workers-list.html  [test/expectations] [2]
LayoutTests/platform/chromium/test_expectations.txt:3892:  Path does not exist. http/tests/inspector-enabled/dedicated-workers-list.html  [test/expectations] [2]
LayoutTests/platform/chromium/test_expectations.txt:3894:  Path does not exist. http/tests/security/cross-frame-access-custom.html  [test/expectations] [2]
Total errors found: 2224 in 19 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Ilya Tikhonovsky]

Created attachment 114928 [details]
[patch] initial version

[WebKit Review Bot]

Attachment 114928 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/insp..." exit_code: 1

Last 3072 characters of output:
ml  [test/expectations] [2]
LayoutTests/platform/chromium/test_expectations.txt:3862:  Path does not exist. svg/zoom/page/relative-sized-document-scrollbars.svg  [test/expectations] [2]
LayoutTests/platform/chromium/test_expectations.txt:3864:  Path does not exist. storage/indexeddb/key-type-array.html  [test/expectations] [2]
LayoutTests/platform/chromium/test_expectations.txt:3866:  Path does not exist. storage/indexeddb/factory-deletedatabase-interactions.html  [test/expectations] [2]
LayoutTests/platform/chromium/test_expectations.txt:3868:  Path does not exist. fast/js/array-functions-non-arrays.html  [test/expectations] [2]
LayoutTests/platform/chromium/test_expectations.txt:3869:  Path does not exist. fast/js/eval-cross-window.html  [test/expectations] [2]
LayoutTests/platform/chromium/test_expectations.txt:3870:  Path does not exist. fast/js/regexp-caching.html  [test/expectations] [2]
LayoutTests/platform/chromium/test_expectations.txt:3871:  Path does not exist. fast/js/toString-overrides.html  [test/expectations] [2]
LayoutTests/platform/chromium/test_expectations.txt:3872:  Path does not exist. fast/js/toString-recursion.html  [test/expectations] [2]
LayoutTests/platform/chromium/test_expectations.txt:3873:  Path does not exist. http/tests/security/xss-eval.html  [test/expectations] [2]
LayoutTests/platform/chromium/test_expectations.txt:3875:  Path does not exist. fast/dom/javascript-url-exception-isolation.html  [test/expectations] [2]
LayoutTests/platform/chromium/test_expectations.txt:3876:  Path does not exist. fast/borders/inline-mask-overlay-image-outset-vertical-rl.html  [test/expectations] [2]
LayoutTests/platform/chromium/test_expectations.txt:3878:  Path does not exist. fast/dom/rtl-scroll-to-leftmost-and-resize.html  [test/expectations] [2]
LayoutTests/platform/chromium/test_expectations.txt:3880:  Path does not exist. accessibility/adjacent-continuations-cause-assertion-failure.html  [test/expectations] [2]
LayoutTests/platform/chromium/test_expectations.txt:3882:  Path does not exist. inspector/debugger/script-formatter.html  [test/expectations] [2]
LayoutTests/platform/chromium/test_expectations.txt:3885:  Path does not exist. fast/js/mozilla/strict/15.4.5.1.html  [test/expectations] [2]
LayoutTests/platform/chromium/test_expectations.txt:3887:  Path does not exist. fast/canvas/canvas-transforms-fillRect-shadow.html  [test/expectations] [2]
LayoutTests/platform/chromium/test_expectations.txt:3889:  Path does not exist. media/track/tracklist-is-reachable.html  [test/expectations] [2]
LayoutTests/platform/chromium/test_expectations.txt:3891:  Path does not exist. http/tests/inspector-enabled/dedicated-workers-list.html  [test/expectations] [2]
LayoutTests/platform/chromium/test_expectations.txt:3892:  Path does not exist. http/tests/inspector-enabled/dedicated-workers-list.html  [test/expectations] [2]
LayoutTests/platform/chromium/test_expectations.txt:3894:  Path does not exist. http/tests/security/cross-frame-access-custom.html  [test/expectations] [2]
Total errors found: 2223 in 19 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Yury Semikhatsky]

Comment on attachment 114928 [details]
[patch] initial version

Clearing r? until we clarify the overall vision and agree on webkitpy changes.

[Ilya Tikhonovsky]

Created attachment 116507 [details]
[patch] third version with the tests in PerformanceTests/inspector

[Yury Semikhatsky]

Comment on attachment 116507 [details]
[patch] third version with the tests in PerformanceTests/inspector

View in context: https://bugs.webkit.org/attachment.cgi?id=116507&action=review

> PerformanceTests/ChangeLog:7
> +        $ run-devtools-perf-test.py --release

run-devtools-perf-test.py should be renamed to run-inspector-perf-tests.py

[Ilya Tikhonovsky]

Created attachment 117407 [details]
Patch

[Pavel Feldman]

Comment on attachment 117407 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=117407&action=review

> PerformanceTests/ChangeLog:3
> +        Web Inspector: chromium: move and adapt Inspector's performance tests for running with run-devtools-perf-tests.py.

It says "move", but I don't see deleted files in this change.

> PerformanceTests/ChangeLog:7
> +        $ run-inspector-perf-tests.py --release

Limiting ChangeLog to this usage line and explaining what it does is sufficient. Otherwise it looks like test results squeezed into the ChangeLog.

[Ilya Tikhonovsky]

Created attachment 117448 [details]
Patch

[Ilya Tikhonovsky]

Committed r101692: <http://trac.webkit.org/changeset/101692>