Bug 72212

Summary: [CMake] Move list of DFG source files into correct file
Product: WebKit Reporter: Patrick R. Gansterer <paroga>
Component: Tools / TestsAssignee: Patrick R. Gansterer <paroga>
Status: RESOLVED FIXED    
Severity: Normal CC: dbates
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch dbates: review+, dbates: commit-queue-

Patrick R. Gansterer
Reported 2011-11-12 06:15:28 PST
[CMake] Move list of DFG source files into correct file
Attachments
Patch (2.86 KB, patch)
2011-11-12 06:20 PST, Patrick R. Gansterer 		dbates: review+
dbates: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Patrick R. Gansterer
Comment 1 2011-11-12 06:20:44 PST
Created attachment 114831 [details] Patch
Daniel Bates
Comment 2 2011-11-12 08:53:14 PST
Comment on attachment 114831 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=114831&action=review > Source/JavaScriptCore/CMakeLists.txt:57 > + dfg/DFGJITCodeGenerator64.cpp > + dfg/DFGJITCodeGenerator32_64.cpp These entries should be reversed so that they appear in sorted order as produced by the Unix sort command. > Source/JavaScriptCore/CMakeLists.txt:59 > + dfg/DFGOperations.cpp This entry should be above dfg/DFGPropagator.cpp so that it appears in this list in sorted order as produced by the Unix sort command. > Source/JavaScriptCore/CMakeLists.txt:64 > + dfg/DFGOSRExitCompiler64.cpp > + dfg/DFGOSRExitCompiler32_64.cpp These entries should be reversed so that they appear in sorted order as produced by the Unix sort command. > Source/JavaScriptCore/CMakeLists.txt:69 > + dfg/DFGSpeculativeJIT64.cpp > + dfg/DFGSpeculativeJIT32_64.cpp Ditto.
Daniel Bates
Comment 3 2011-11-12 08:54:05 PST
Comment on attachment 114831 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=114831&action=review > Source/JavaScriptCore/ChangeLog:8 > + The DFG files are platform independet. So move them from independet => independent
Patrick R. Gansterer
Comment 4 2011-11-12 09:31:17 PST
Committed r100081: <http://trac.webkit.org/changeset/100081>
Note You need to log in before you can comment on or make changes to this bug.