Bug 72207

Summary:

Web Inspector: Give HTML ContextMenu a more Native look

Product:

WebKit

Reporter:

Joseph Pecoraro <joepeck>

Component:

Web Inspector (Deprecated)

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

apavlov, bweinstein, joepeck, keishi, loislo, pfeldman, pmuellr, rik, timothy, webkit.review.bot, yurys

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
[IMAGE] Comparison of Styles (Current, After Patch, Native)	none
[PATCH] First Draft	none
[IMAGE] Compare Gradient vs Non-Gradient (for patch 2)	none
[PATCH] Addressed Some Comments	none

Joseph Pecoraro

Reported 2011-11-12 00:10:40 PST

Created attachment 114822 [details] [IMAGE] Comparison of Styles (Current, After Patch, Native) I assume this will work for Chrome on platform-mac too. Is it worth making this the default style, or do Chrome's users expect a different style? Let me know, I'm open to changing this. I just spent some time tonight playing with it for fun. See attached photo. left = current style mid = this patch's style right = native style

Attachments
[IMAGE] Comparison of Styles (Current, After Patch, Native) (260.46 KB, image/png) 2011-11-12 00:10 PST, Joseph Pecoraro	no flags	Details
[PATCH] First Draft (2.46 KB, patch) 2011-11-12 00:12 PST, Joseph Pecoraro	no flags	Details Formatted Diff Diff
[IMAGE] Compare Gradient vs Non-Gradient (for patch 2) (24.72 KB, image/png) 2011-11-13 14:47 PST, Joseph Pecoraro	no flags	Details
[PATCH] Addressed Some Comments (4.05 KB, patch) 2011-11-13 14:47 PST, Joseph Pecoraro	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Joseph Pecoraro

Comment 1 2011-11-12 00:12:07 PST

Created attachment 114823 [details] [PATCH] First Draft

Pavel Feldman

Comment 2 2011-11-12 11:53:43 PST

> I assume this will work for Chrome on platform-mac too. Is it worth making > this the default style, or do Chrome's users expect a different style? Let me know, > I'm open to changing this. I just spent some time tonight playing with it for fun. > Originally, I styled the context menu with Mac in mind. Obviously you've done a much better job. I was going to suggest that you make it default, but then I though that gradients might be too much to the Windows user base. So, as a compromise, could you update the default styles to have fixed geometry + Mac's colors for borders + define gradients in the Mac's port styles? I would then be able to add overrides say for Windows 7 and GTK. ... HTML5 menus, where are you ?!?

Pavel Feldman

Comment 3 2011-11-12 11:56:11 PST

> So, as a compromise, could you update the default styles to have fixed geometry + Mac's colors for borders + define gradients in the Mac's port styles? I would then be able to add overrides say for Windows 7 and GTK. Using "+" too much. Re-iterating for clarity: - Default styles to have new geometry and Mac's plain colors - Mac port has gradients.

Joseph Pecoraro

Comment 4 2011-11-13 14:47:08 PST

Created attachment 114864 [details] [IMAGE] Compare Gradient vs Non-Gradient (for patch 2)

Joseph Pecoraro

Comment 5 2011-11-13 14:47:38 PST

Created attachment 114865 [details] [PATCH] Addressed Some Comments

WebKit Review Bot

Comment 6 2011-11-14 01:40:53 PST

Comment on attachment 114865 [details] [PATCH] Addressed Some Comments Clearing flags on attachment: 114865 Committed r100114: <http://trac.webkit.org/changeset/100114>

WebKit Review Bot

Comment 7 2011-11-14 01:40:58 PST

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.