Bug 72169 – [Qt] FrameLoaderClientQt::canShowMIMEType should always return true

• Component: WebKit Qt
• Status: RESOLVED INVALID

[Jesus Sanchez-Palencia]

Currently FrameLoaderClientQt::canShowMIMEType is called after dispatchDecidePolicyForResponse. We might have a bug if decidePolicyForResponse returns PolicyUse while canShowMIMEType returns false.

We should keep this implementation in WK1 as in WK2, always returning true.

[Jesus Sanchez-Palencia]

Created attachment 114758 [details]
Patch

[Simon Hausmann]

Comment on attachment 114758 [details]
Patch

r=me

[WebKit Review Bot]

Comment on attachment 114758 [details]
Patch

Clearing flags on attachment: 114758

Committed r100448: <http://trac.webkit.org/changeset/100448>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.

[Csaba Osztrogonác]

It broke a test:

--- /ramdisk/qt-linux-release/build/layout-test-results/http/tests/loading/text-content-type-with-binary-extension-expected.txt 
+++ /ramdisk/qt-linux-release/build/layout-test-results/http/tests/loading/text-content-type-with-binary-extension-actual.txt 
@@ -2,11 +2,14 @@
 main frame - didCommitLoadForFrame
 frame "iframe" - didStartProvisionalLoadForFrame
 main frame - didFinishDocumentLoadForFrame
+frame "iframe" - didCommitLoadForFrame
+frame "iframe" - didFinishDocumentLoadForFrame
+frame "iframe" - didHandleOnloadEventsForFrame
 main frame - didHandleOnloadEventsForFrame
-frame "iframe" - didFailProvisionalLoadWithError
+frame "iframe" - didFinishLoadForFrame
 main frame - didFinishLoadForFrame
 Test for https://bugs.webkit.org/show_bug.cgi?id=17360 REGRESSION: mp4 file downloaded from server is downloaded as html.
 
-Binary data not loaded as text. Maybe PASS.
+FAIL

[Jesus Sanchez-Palencia]

(In reply to comment #5)
> It broke a test:

Ossy, why can't I see this in http://build.webkit.org/console?category=core ?!
Or am I missing something there?

[Csaba Osztrogonác]

(In reply to comment #6)
> (In reply to comment #5)
> > It broke a test:
> 
> Ossy, why can't I see this in http://build.webkit.org/console?category=core ?!
> Or am I missing something there?

You should see orange bubble here, which means that bot is red and it was red before your patch. But it doesn't inform you if there is additional failing test or not. You should check waterfall.

[Csaba Osztrogonác]

Reopen, because it was rolled out: http://trac.webkit.org/changeset/100459

[Jocelyn Turcotte]

=== Bulk closing of Qt bugs ===

If you believe that this bug report is still relevant for a non-Qt port of webkit.org, please re-open it and remove [Qt] from the summary.

If you believe that this is still an important QtWebKit bug, please fill a new report at https://bugreports.qt-project.org and add a link to this issue. See http://qt-project.org/wiki/ReportingBugsInQt for additional guidelines.