Bug 72097

Summary:

Compile error with gcc 4.6 (-Werror)

Product:

WebKit

Reporter:

Halton Huo <halton.huo>

Component:

WebCore Misc.

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Major

CC:

cc-bugs, jamesr, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none

Description Halton Huo 2011-11-11 00:33:26 PST

Compile chromium with following environement:
OS: Ubuntu 11.10
GCC: 4.6.1
Chromium: svn://svn.chromium.org/chrome/trunk/src@109591
WebKit: http://svn.webkit.org/repository/webkit/trunk@99883

third_party/WebKit/Source/WebCore/platform/graphics/chromium/TiledLayerChromium.cpp: In member function ‘void WebCore::TiledLayerChromium::prepareToUpdate(const WebCore::IntRect&)’:
third_party/WebKit/Source/WebCore/platform/graphics/chromium/TiledLayerChromium.cpp:387:28: error: variable ‘anchor’ set but not used [-Werror=unused-but-set-variable]
  CXX(target) out/Debug/obj.target/webcore_platform/third_party/WebKit/Source/WebCore/platform/graphics/chromium/cc/CCFrameRateController.o
cc1plus: all warnings being treated as errors

Comment 1 Halton Huo 2011-11-11 00:43:50 PST

Created attachment 114641 [details]
Patch

Comment 2 Andreas Kling 2011-11-11 04:01:39 PST

Comment on attachment 114641 [details]
Patch

rs=me

Comment 3 WebKit Review Bot 2011-12-21 15:20:16 PST

Comment on attachment 114641 [details]
Patch

Rejecting attachment 114641 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
dreas Kling', u'--fo..." exit_code: 1

Parsed 2 diffs from patch file(s).
patching file Source/WebCore/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.
patching file Source/WebCore/platform/graphics/chromium/TiledLayerChromium.cpp
Hunk #1 FAILED at 384.
1 out of 1 hunk FAILED -- saving rejects to file Source/WebCore/platform/graphics/chromium/TiledLayerChromium.cpp.rej

Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--reviewer', u'Andreas Kling', u'--fo..." exit_code: 1

Full output: http://queues.webkit.org/results/10997154

Comment 4 James Robinson 2011-12-21 15:24:54 PST

Comment on attachment 114641 [details]
Patch

Patch doesn't apply any more, clearing flags

Comment 5 Halton Huo 2011-12-21 17:46:19 PST

This patch is already in master, this bug is invalid now.