Bug 72049

Summary: Specify testapi.js install path using JAVASCRIPTCORE_FRAMEWORKS_DIR
Product: WebKit Reporter: David Kilzer (:ddkilzer) <ddkilzer>
Component: JavaScriptCoreAssignee: David Kilzer (:ddkilzer) <ddkilzer>
Status: RESOLVED FIXED    
Severity: Normal CC: ggaren, joepeck, webkit.review.bot
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch joepeck: review+

David Kilzer (:ddkilzer)
Reported 2011-11-10 13:09:51 PST
Created attachment 114551 [details] Patch Reviewed by NOBODY (OOPS!). * JavaScriptCore.xcodeproj/project.pbxproj: The testapi.js script should use JAVASCRIPTCORE_FRAMEWORKS_DIR in its dstPath for installation. Also removed "Versions/A/" from the path since this is unneeded due the default symlinks present in the framework. --- 2 files changed, 13 insertions(+), 1 deletions(-)
Attachments
Patch (1.68 KB, patch)
2011-11-10 13:09 PST, David Kilzer (:ddkilzer) 		joepeck: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
WebKit Review Bot
Comment 1 2011-11-10 13:12:17 PST
Attachment 114551 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source..." exit_code: 1 Source/JavaScriptCore/ChangeLog:1: ChangeLog entry has no bug number [changelog/bugnumber] [5] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.
David Kilzer (:ddkilzer)
Comment 2 2011-11-10 15:33:09 PST
Committed r99906: <http://trac.webkit.org/changeset/99906>
David Kilzer (:ddkilzer)
Comment 3 2011-11-10 15:44:28 PST
<rdar://problem/10423071>
Note You need to log in before you can comment on or make changes to this bug.